[3PCD] Clean up 3PCD WebUI logic [chromium/src : main]
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling added 2 comments![]( "Open in Gerrit")
$i18n{trackingProtectionPageDescription}Please clean up all strings that are not longer needed. (Applies to all strings in all affected files.)
<cr-icon icon="settings:visibility-off" aria-hidden="true">Please clean up all icons that are no longer needed. (Applies to all strings in all affected files.)
Related details
- Fiona Macintosh
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling added 1 comment![]( "Open in Gerrit")
Apologies, I think I just jumped on this CL when it wasn't yet sent for review (I got notified bcs this CL is in my watchlist, and didn't read the email well enough - sorry about that! No pressure from my end, send it for review whenever it's ready :) )
Related details
- Fiona Macintosh
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+1![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh added 2 comments![]( "Open in Gerrit")
$i18n{trackingProtectionPageDescription}Please clean up all strings that are not longer needed. (Applies to all strings in all affected files.)
Done
<cr-icon icon="settings:visibility-off" aria-hidden="true">Please clean up all icons that are no longer needed. (Applies to all strings in all affected files.)
Done
Related details
- John Lee
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling voted and added 4 comments![]( "Open in Gerrit")
Votes added by Rainhard Findling
| Code-Review | +1 |
4 comments
<cr-icon icon="settings:domain-verification" aria-hidden="true">It seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
test('MSBB', async function() {Let's not remove the test where only the MSBB step is visible, which is the minimum flow length, hence one end of the spectrum.
Let's instead separately test some key cases where the cookies card is visible.
IN_PROC_BROWSER_TEST_F(SettingsPrivacyGuideTest, SafeBrowsingCardNavigations) {Thx! :)
Related details
- Fiona Macintosh
- John Lee
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted and added 2 comments![]( "Open in Gerrit")
Votes added by Fiona Macintosh
| Commit-Queue | +1 |
2 comments
<cr-icon icon="settings:domain-verification" aria-hidden="true">It seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
Yes, I believe it was intentional by the UX team. Also note that the change in this CL is to clean up Mode B (3PCD 1%) logic, in which users did not even see the cookies Privacy Guide step, so this icon has not been aligned with the 99+% user population for a long time. If you would like to follow up with the UX team that created this design I would reach out to mbodas@ and she can give you more context, or direct you to someone who can
test('MSBB', async function() {Let's not remove the test where only the MSBB step is visible, which is the minimum flow length, hence one end of the spectrum.
Let's instead separately test some key cases where the cookies card is visible.
I have re-added the MSBB and MSBB_HistorySync tests. If there are other "key cases" I'm missing please feel free to reopen but this brings the tests back to parity with its prior coverage, just moving the Cookies tests up into this suite
Related details
- John Lee
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- John Lee
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rainhard Findling
| Code-Review | +1 |
1 comment
<cr-icon icon="settings:domain-verification" aria-hidden="true">Fiona MacintoshIt seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
Yes, I believe it was intentional by the UX team. Also note that the change in this CL is to clean up Mode B (3PCD 1%) logic, in which users did not even see the cookies Privacy Guide step, so this icon has not been aligned with the 99+% user population for a long time. If you would like to follow up with the UX team that created this design I would reach out to mbodas@ and she can give you more context, or direct you to someone who can
Yes, please initiate that the UX team who intentionally wants there to be a difference between the 3P cookie choice in the cookies_page and in Privacy Guide to reach out to me - I'd love to understand their reasons for why they'd intentionally want such a difference, and how we could unify the descriptions.
Related details
- Fiona Macintosh
- John Lee
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh added 1 comment![]( "Open in Gerrit")
<cr-icon icon="settings:domain-verification" aria-hidden="true">Fiona MacintoshIt seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
Rainhard FindlingYes, I believe it was intentional by the UX team. Also note that the change in this CL is to clean up Mode B (3PCD 1%) logic, in which users did not even see the cookies Privacy Guide step, so this icon has not been aligned with the 99+% user population for a long time. If you would like to follow up with the UX team that created this design I would reach out to mbodas@ and she can give you more context, or direct you to someone who can
Yes, please initiate that the UX team who intentionally wants there to be a difference between the 3P cookie choice in the cookies_page and in Privacy Guide to reach out to me - I'd love to understand their reasons for why they'd intentionally want such a difference, and how we could unify the descriptions.
With the last reorg, my team will no longer be working on the Privacy Guide in any capacity and I do not believe that having me as an intermediary will be conducive to your conversation with Chrome UX. Therefore, I would advise you reach out to Maranda (mbodas@) yourself to initiate a conversation about concerns with the current design. You could say something like: "Hi Maranda, I was added as a reviewer on crrev.com/c/7252270 and it was brought to my attention that there are content and icon differences across the third-party cookie settings page and the third-party cookie privacy guide step. I have some concerns about this and would like to engage with the designer(s) who originally worked on this to understand how this came to be."
Related details
- John Lee
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling voted and added 2 comments![]( "Open in Gerrit")
Votes added by Rainhard Findling
| Code-Review | +0 |
2 comments
Please attach a screenshot of what the UI looks like with this CL [[1](https://docs.google.com/document/d/1pJxZ80cetPGTjyOzc8TgL0nat2wLUXnpfTxuZWgIV2s/edit?resourcekey=0-ffcQ5e8VmHIp6yUsZ1QNrw&tab=t.0#heading=h.fjrg2p17suk5)]
<cr-icon icon="settings:domain-verification" aria-hidden="true">Fiona MacintoshIt seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
Rainhard FindlingYes, I believe it was intentional by the UX team. Also note that the change in this CL is to clean up Mode B (3PCD 1%) logic, in which users did not even see the cookies Privacy Guide step, so this icon has not been aligned with the 99+% user population for a long time. If you would like to follow up with the UX team that created this design I would reach out to mbodas@ and she can give you more context, or direct you to someone who can
Fiona MacintoshYes, please initiate that the UX team who intentionally wants there to be a difference between the 3P cookie choice in the cookies_page and in Privacy Guide to reach out to me - I'd love to understand their reasons for why they'd intentionally want such a difference, and how we could unify the descriptions.
With the last reorg, my team will no longer be working on the Privacy Guide in any capacity and I do not believe that having me as an intermediary will be conducive to your conversation with Chrome UX. Therefore, I would advise you reach out to Maranda (mbodas@) yourself to initiate a conversation about concerns with the current design. You could say something like: "Hi Maranda, I was added as a reviewer on crrev.com/c/7252270 and it was brought to my attention that there are content and icon differences across the third-party cookie settings page and the third-party cookie privacy guide step. I have some concerns about this and would like to engage with the designer(s) who originally worked on this to understand how this came to be."
Thx for the background!
To clarify: If changes are made to the cookies_page, then it's important to also have a plan and agreement for updating the cookies UI in Privacy Guide accordingly - so that the choices shown in both are aligned with each other. Working on the cookies_page hence by design means ensuring the cookies UI in privacy guide is kept in sync.
I'll temporarily pull back my +1 to ensure we are aligned on this plan, and to ensure I have a direct comparison of the cookies page after this CL (see my other comment about the screenshot) with the cookies UI in privacy guide.
Related details
- Fiona Macintosh
- John Lee
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted and added 2 comments![]( "Open in Gerrit")
Votes added by Fiona Macintosh
| Commit-Queue | +1 |
Please attach a screenshot of what the UI looks like with this CL [[1](https://docs.google.com/document/d/1pJxZ80cetPGTjyOzc8TgL0nat2wLUXnpfTxuZWgIV2s/edit?resourcekey=0-ffcQ5e8VmHIp6yUsZ1QNrw&tab=t.0#heading=h.fjrg2p17suk5)]
See other comment, this simply removes one of the two variants of the third-party cookie settings page that previously existed.
<cr-icon icon="settings:domain-verification" aria-hidden="true">Fiona MacintoshIt seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
Rainhard FindlingYes, I believe it was intentional by the UX team. Also note that the change in this CL is to clean up Mode B (3PCD 1%) logic, in which users did not even see the cookies Privacy Guide step, so this icon has not been aligned with the 99+% user population for a long time. If you would like to follow up with the UX team that created this design I would reach out to mbodas@ and she can give you more context, or direct you to someone who can
Fiona MacintoshYes, please initiate that the UX team who intentionally wants there to be a difference between the 3P cookie choice in the cookies_page and in Privacy Guide to reach out to me - I'd love to understand their reasons for why they'd intentionally want such a difference, and how we could unify the descriptions.
Rainhard FindlingWith the last reorg, my team will no longer be working on the Privacy Guide in any capacity and I do not believe that having me as an intermediary will be conducive to your conversation with Chrome UX. Therefore, I would advise you reach out to Maranda (mbodas@) yourself to initiate a conversation about concerns with the current design. You could say something like: "Hi Maranda, I was added as a reviewer on crrev.com/c/7252270 and it was brought to my attention that there are content and icon differences across the third-party cookie settings page and the third-party cookie privacy guide step. I have some concerns about this and would like to engage with the designer(s) who originally worked on this to understand how this came to be."
Thx for the background!
To clarify: If changes are made to the cookies_page, then it's important to also have a plan and agreement for updating the cookies UI in Privacy Guide accordingly - so that the choices shown in both are aligned with each other. Working on the cookies_page hence by design means ensuring the cookies UI in privacy guide is kept in sync.
I'll temporarily pull back my +1 to ensure we are aligned on this plan, and to ensure I have a direct comparison of the cookies page after this CL (see my other comment about the screenshot) with the cookies UI in privacy guide.
I guess I should be clearer about what this CL is doing. Previously there were 2 versions of the cookies page: one for users in the 3PCD 1% experiment (who *did not see the cookies privacy guide step* - see privacy guide logic being removed) and one for the rest of the Chrome user base. Now that the 3PCD experiment has ended and been rolled back this CL simply deletes the first UI. There are no "changes" being made to the cookies page in the traditional sense; this CL simply cleans up a UI that was created for a now-non-existent user population.
Does that make sense to you? I will also move this into the CL description, I apologize as I thought it was pretty clear from the changes in the CL.
Related details
- John Lee
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rainhard Findling
| Code-Review | +1 |
1 comment
<cr-icon icon="settings:domain-verification" aria-hidden="true">Fiona MacintoshIt seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
Rainhard FindlingYes, I believe it was intentional by the UX team. Also note that the change in this CL is to clean up Mode B (3PCD 1%) logic, in which users did not even see the cookies Privacy Guide step, so this icon has not been aligned with the 99+% user population for a long time. If you would like to follow up with the UX team that created this design I would reach out to mbodas@ and she can give you more context, or direct you to someone who can
Fiona MacintoshYes, please initiate that the UX team who intentionally wants there to be a difference between the 3P cookie choice in the cookies_page and in Privacy Guide to reach out to me - I'd love to understand their reasons for why they'd intentionally want such a difference, and how we could unify the descriptions.
Rainhard FindlingWith the last reorg, my team will no longer be working on the Privacy Guide in any capacity and I do not believe that having me as an intermediary will be conducive to your conversation with Chrome UX. Therefore, I would advise you reach out to Maranda (mbodas@) yourself to initiate a conversation about concerns with the current design. You could say something like: "Hi Maranda, I was added as a reviewer on crrev.com/c/7252270 and it was brought to my attention that there are content and icon differences across the third-party cookie settings page and the third-party cookie privacy guide step. I have some concerns about this and would like to engage with the designer(s) who originally worked on this to understand how this came to be."
Fiona MacintoshThx for the background!
To clarify: If changes are made to the cookies_page, then it's important to also have a plan and agreement for updating the cookies UI in Privacy Guide accordingly - so that the choices shown in both are aligned with each other. Working on the cookies_page hence by design means ensuring the cookies UI in privacy guide is kept in sync.
I'll temporarily pull back my +1 to ensure we are aligned on this plan, and to ensure I have a direct comparison of the cookies page after this CL (see my other comment about the screenshot) with the cookies UI in privacy guide.
I guess I should be clearer about what this CL is doing. Previously there were 2 versions of the cookies page: one for users in the 3PCD 1% experiment (who *did not see the cookies privacy guide step* - see privacy guide logic being removed) and one for the rest of the Chrome user base. Now that the 3PCD experiment has ended and been rolled back this CL simply deletes the first UI. There are no "changes" being made to the cookies page in the traditional sense; this CL simply cleans up a UI that was created for a now-non-existent user population.
Does that make sense to you? I will also move this into the CL description, I apologize as I thought it was pretty clear from the changes in the CL.
True that, that's a fair point. I did indeed not spot that none of the differences between the old cookies page and the cookies UI in privacy guide did stem from the 3PCD codepath or from a change made in this this CL. In that case feel free to land as is.
And for future changes to cookies page: let's ensure we also have a plan for the cookies UI in privacy guide :)
Related details
- Fiona Macintosh
- John Lee
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh added 1 comment![]( "Open in Gerrit")
<cr-icon icon="settings:domain-verification" aria-hidden="true">Fiona MacintoshIt seems that while this icon is no longer used in the cookies_page, the privacy guide cookies card still uses it - is that intentional?
In general, should what the privacy guide cookies card shows be aligned 1:1 with what the cookies_page shows, as in icons and strings? If yes please verify that's actually the case.
(Happy to TAL again in case you make further changes in this CL, but feel free to follow-up in a separate CL)
Rainhard FindlingYes, I believe it was intentional by the UX team. Also note that the change in this CL is to clean up Mode B (3PCD 1%) logic, in which users did not even see the cookies Privacy Guide step, so this icon has not been aligned with the 99+% user population for a long time. If you would like to follow up with the UX team that created this design I would reach out to mbodas@ and she can give you more context, or direct you to someone who can
Fiona MacintoshYes, please initiate that the UX team who intentionally wants there to be a difference between the 3P cookie choice in the cookies_page and in Privacy Guide to reach out to me - I'd love to understand their reasons for why they'd intentionally want such a difference, and how we could unify the descriptions.
Rainhard FindlingWith the last reorg, my team will no longer be working on the Privacy Guide in any capacity and I do not believe that having me as an intermediary will be conducive to your conversation with Chrome UX. Therefore, I would advise you reach out to Maranda (mbodas@) yourself to initiate a conversation about concerns with the current design. You could say something like: "Hi Maranda, I was added as a reviewer on crrev.com/c/7252270 and it was brought to my attention that there are content and icon differences across the third-party cookie settings page and the third-party cookie privacy guide step. I have some concerns about this and would like to engage with the designer(s) who originally worked on this to understand how this came to be."
Fiona MacintoshThx for the background!
To clarify: If changes are made to the cookies_page, then it's important to also have a plan and agreement for updating the cookies UI in Privacy Guide accordingly - so that the choices shown in both are aligned with each other. Working on the cookies_page hence by design means ensuring the cookies UI in privacy guide is kept in sync.
I'll temporarily pull back my +1 to ensure we are aligned on this plan, and to ensure I have a direct comparison of the cookies page after this CL (see my other comment about the screenshot) with the cookies UI in privacy guide.
Rainhard FindlingI guess I should be clearer about what this CL is doing. Previously there were 2 versions of the cookies page: one for users in the 3PCD 1% experiment (who *did not see the cookies privacy guide step* - see privacy guide logic being removed) and one for the rest of the Chrome user base. Now that the 3PCD experiment has ended and been rolled back this CL simply deletes the first UI. There are no "changes" being made to the cookies page in the traditional sense; this CL simply cleans up a UI that was created for a now-non-existent user population.
Does that make sense to you? I will also move this into the CL description, I apologize as I thought it was pretty clear from the changes in the CL.
True that, that's a fair point. I did indeed not spot that none of the differences between the old cookies page and the cookies UI in privacy guide did stem from the 3PCD codepath or from a change made in this this CL. In that case feel free to land as is.
And for future changes to cookies page: let's ensure we also have a plan for the cookies UI in privacy guide :)
- John Lee
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
John Lee (Gerrit)
John Lee voted Code-Review+1![]( "Open in Gerrit")
- Fiona Macintosh
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fiona Macintosh (Gerrit)
Fiona Macintosh voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[3PCD] Clean up 3PCD WebUI logic
Previously there were 2 versions of the third-party cookie settings
page: one for users in the 3PCD 1% experiment (who did not see the
cookies privacy guide step - see privacy guide logic being removed) and
one for the rest of the Chrome user base. Now that the 3PCD experiment
has ended and been rolled back this CL deletes the UI that was built
and shown only to 3PCD 1% users.
- M chrome/app/settings_strings.grdp
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_BULLET_ONE.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_BULLET_ONE_DESCRIPTION.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_BULLET_TWO.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_BULLET_TWO_DESCRIPTION.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_BULLET_TWO_LEARN_MORE_ARIA_LABEL.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_PAGE_DESCRIPTION.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_THIRD_PARTY_COOKIES_LEARN_MORE_ARIA_LABEL.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_THIRD_PARTY_COOKIES_TOGGLE_LABEL.png.sha1
- D chrome/app/settings_strings_grdp/IDS_SETTINGS_TRACKING_PROTECTION_THIRD_PARTY_COOKIES_TOGGLE_SUB_LABEL.png.sha1
- M chrome/browser/resources/settings/icons.html
- M chrome/browser/resources/settings/privacy_page/cookies_page.html
- M chrome/browser/resources/settings/privacy_page/cookies_page.ts
- M chrome/browser/resources/settings/privacy_page/privacy_guide/privacy_guide_cookies_fragment.ts
- M chrome/browser/resources/settings/privacy_page/privacy_guide/privacy_guide_page.ts
- M chrome/browser/resources/settings/privacy_page/privacy_page.ts
- M chrome/browser/resources/settings/site_settings/site_settings_list.ts
- M chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
- M chrome/browser/ui/webui/settings/settings_ui.cc
- M chrome/common/url_constants.h
- M chrome/test/data/webui/settings/cookies_page_test.ts
- M chrome/test/data/webui/settings/privacy_guide_integration_test.ts
- M chrome/test/data/webui/settings/privacy_guide_page_test.ts
- M chrome/test/data/webui/settings/privacy_guide_test_util.ts
- M chrome/test/data/webui/settings/privacy_page_test.ts
- M chrome/test/data/webui/settings/settings_browsertest.cc
- M chrome/test/data/webui/settings/site_settings_page_test.ts
Code-Review: +1 by John Lee, +1 by Rainhard Findling
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |