Yang Guo (Gerrit)

unread,

9:11 AM (3 hours ago) 9:11 AM

to Alex Rudenko, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko

Yang Guo voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

9:12 AM (3 hours ago) 9:12 AM

to Yang Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Yang Guo

Alex Rudenko voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Yang Guo

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

9:43 AM (3 hours ago) 9:43 AM

to Yang Guo, Alex Rudenko, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[DevTools] Rebaseline and temporarily disable locations-a11y-test.js

http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js is
rebaselined for the new error message ("can’t be empty") in
devtools-frontend (https://crrev.com/c/8064957).

To allow a clean three-way roll across devtools-frontend and Chromium,
the test is also temporarily disabled in TestExpectations.

Bug: 531625963

Change-Id: Ief90361c2df4b0a521bbaf99bb288941e3201315

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8063491

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Commit-Queue: Alex Rudenko <alexr...@chromium.org>

Commit-Queue: Yang Guo <yan...@chromium.org>

Auto-Submit: Yang Guo <yan...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1658696}

Files:

M third_party/blink/web_tests/TestExpectations
M third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/settings/locations-a11y-test-expected.txt

Change size: XS

Delta: 2 files changed, 4 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alex Rudenko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[DevTools] Rebaseline and temporarily disable locations-a11y-test.js [chromium/src : main]

Yang Guo (Gerrit)

Yang Guo voted

Related details

Alex Rudenko (Gerrit)

Alex Rudenko voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information