[Glic] Prevent daisy-chaining side panel in ActivateTabWithUrl [chromium/src : main]
0 views
Skip to first unread message
Bryant Chandler (Gerrit)
Jul 8, 2026, 5:41:09 PM (10 hours ago) Jul 8
to Rosie Yang, Theodore Olsauskas-Warren, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Rosie Yang
Bryant Chandler added 1 comment![]( "Open in Gerrit")
File chrome/browser/glic/service/glic_instance_impl.cc
Line 673, Patchset 3 (Latest):
if (is_onboarding || prevent_daisy_chain) {Bryant Chandler . unresolved
This is bypassing daisy chaining entirely, but it seems like we actually just want to prevent show. Daisy chaining the binding is important to the user experience. We should do that instead. Note the branch below on line 290 where we call BindTab instead of show.
Related details
Attention is currently required from:
- Rosie Yang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rosie Yang (Gerrit)
Jul 8, 2026, 6:21:47 PM (9 hours ago) Jul 8
to Theodore Olsauskas-Warren, Chromium LUCI CQ, Bryant Chandler, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Bryant Chandler
Rosie Yang added 1 comment![]( "Open in Gerrit")
File chrome/browser/glic/service/glic_instance_impl.cc
This is bypassing daisy chaining entirely, but it seems like we actually just want to prevent show. Daisy chaining the binding is important to the user experience. We should do that instead. Note the branch below on line 290 where we call BindTab instead of show.
Rosie Yang
Done. Good catch!
Updated Patchset 4 so that when `prevent_daisy_chain` is true, we call `BindTab()` instead of `Show()`.
Related details
Attention is currently required from:
- Bryant Chandler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bryant Chandler (Gerrit)
Jul 8, 2026, 6:25:10 PM (9 hours ago) Jul 8
to Rosie Yang, Theodore Olsauskas-Warren, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Rosie Yang
Bryant Chandler added 1 comment![]( "Open in Gerrit")
File chrome/browser/glic/service/glic_instance_impl.cc
Line 688, Patchset 4 (Latest):
if (prevent_daisy_chain ||Bryant Chandler . unresolved
This would need to be renamed to show_side_panel and default to true.
Related details
Attention is currently required from:
- Rosie Yang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rosie Yang (Gerrit)
Jul 8, 2026, 6:33:32 PM (9 hours ago) Jul 8
to Theodore Olsauskas-Warren, Chromium LUCI CQ, Bryant Chandler, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Bryant Chandler
Rosie Yang added 1 comment![]( "Open in Gerrit")
File chrome/browser/glic/service/glic_instance_impl.cc
This would need to be renamed to show_side_panel and default to true.
Attention is currently required from:
- Bryant Chandler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bryant Chandler (Gerrit)
Jul 8, 2026, 6:48:59 PM (8 hours ago) Jul 8
to Rosie Yang, Theodore Olsauskas-Warren, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Rosie Yang
Bryant Chandler voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rosie Yang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rosie Yang (Gerrit)
Jul 8, 2026, 7:21:59 PM (8 hours ago) Jul 8
to Bryant Chandler, Theodore Olsauskas-Warren, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dewitt...@chromium.org
Rosie Yang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2026, 10:42:55 PM (5 hours ago) Jul 8
to Rosie Yang, Bryant Chandler, Theodore Olsauskas-Warren, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dewitt...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/glic/service/glic_instance_impl.cc
Insertions: 8, Deletions: 6.
@@ -682,12 +682,14 @@
return;
}
- // If the floating UI is active and the feature flag is enabled, or if
- // showing the side panel is not requested, we only bind the tab instead of
- // showing it.
- if (!show_side_panel || (base::FeatureList::IsEnabled(
- kGlicBindOnlyForDaisyChainingFromFloatingUi) &&
- IsDetached())) {
+ // If showing the side panel is not requested, we only bind the tab.
+ if (!show_side_panel) {
+ BindTab(created_tab, GlicPinTrigger::kDaisyChain, /*pin_on_bind=*/true);
+ } else if (base::FeatureList::IsEnabled(
+ kGlicBindOnlyForDaisyChainingFromFloatingUi) &&
+ IsDetached()) {
+ // If the floating UI is active and the feature flag is enabled, bind the
+ // tab and keep focus on the floating UI.
BindTab(created_tab, GlicPinTrigger::kDaisyChain, /*pin_on_bind=*/true);
if (embedder_has_focus) {
GetActiveEmbedder()->Focus();
```
Change information
Commit message:
[Glic] Prevent daisy-chaining side panel in ActivateTabWithUrl
When ActivateTabWithUrl does not match an existing tab and falls back to
calling CreateTab(), CreateTab() previously defaulted to calling Show()
and daisy-chaining the Glic side panel onto the newly created tab.
This CL prevents unwanted showing of the Glic side panel when returning
to or activating the Gemini Spark website tab by:
* Passing `show_side_panel = false` when GlicPageHandler::ActivateTabWithUrl falls back to creating a new tab.
* Adding an optional `show_side_panel = true` parameter to Host::InstanceDelegate::CreateTab() and GlicInstanceImpl::CreateTab().
* Calling BindTab() instead of Show() in GlicInstanceImpl::CreateTab() when `show_side_panel` is false, keeping the side panel hidden on the target tab while preserving Glic instance binding continuity.
Result:http://shortn/_R4usYfG84S
Bug: b:532254279
Change-Id: I66f9f04858b649814bc6b42c70c103479e3f4c5c
Reviewed-by: Bryant Chandler <bryantc...@chromium.org>
Commit-Queue: Rosie Yang <ros...@google.com>
Cr-Commit-Position: refs/heads/main@{#1659246}
Files:
- M chrome/browser/glic/host/glic_page_handler.cc
- M chrome/browser/glic/host/host.h
- M chrome/browser/glic/service/glic_instance_coordinator_browsertest.cc
- M chrome/browser/glic/service/glic_instance_impl.cc
- M chrome/browser/glic/service/glic_instance_impl.h
- M chrome/test/data/webui/glic/browser_tests/new_glic_api_browsertest.ts
Change size: M
Delta: 6 files changed, 48 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Bryant Chandler
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages