settings: Move On-device AI toggle to chrome://settings/ai [chromium/src : main]
0 views
Skip to first unread message
Jim Pollock (Gerrit)
1:58 AM (17 hours ago) 1:58 AM
to Reilly Grant, chromium...@chromium.org, rainhar...@chromium.org, srahim...@chromium.org
Attention needed from Reilly Grant
Jim Pollock voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jim Pollock (Gerrit)
1:59 AM (17 hours ago) 1:59 AM
to Chromium LUCI CQ, Reilly Grant, chromium...@chromium.org, rainhar...@chromium.org, srahim...@chromium.org
Attention needed from Reilly Grant
Jim Pollock voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jim Pollock (Gerrit)
2:14 AM (17 hours ago) 2:14 AM
to Chromium LUCI CQ, Reilly Grant, chromium...@chromium.org, rainhar...@chromium.org, srahim...@chromium.org
Attention needed from Reilly Grant
Jim Pollock voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jim Pollock (Gerrit)
2:26 AM (16 hours ago) 2:26 AM
to Chromium LUCI CQ, Reilly Grant, chromium...@chromium.org, rainhar...@chromium.org, srahim...@chromium.org
Attention needed from Reilly Grant
Jim Pollock voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Reilly Grant
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
3:26 PM (3 hours ago) 3:26 PM
to Jim Pollock, Thomas Lukaszewicz, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, rainhar...@chromium.org, srahim...@chromium.org
Attention needed from Jim Pollock and Thomas Lukaszewicz
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Reilly Grant
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Reilly Grant . resolved
LGTM. Thomas, please do a WebUI review.
Related details
Attention is currently required from:
- Jim Pollock
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
4:35 PM (2 hours ago) 4:35 PM
to Jim Pollock, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, rainhar...@chromium.org, srahim...@chromium.org
Attention needed from Jim Pollock
Thomas Lukaszewicz added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Thomas Lukaszewicz . resolved
Overall looks reasonable - just a QQ on an unused method
File chrome/browser/resources/settings/ai_page/ai_page.ts
Line 244, Patchset 6 (Latest):
private onOnDeviceAiSendFeedback_(e: Event) {Thomas Lukaszewicz . unresolved
This method seems to be unused (it was previously used in `settings-section` but that appears to have been removed) - though I may be wrong
Related details
Attention is currently required from:
- Jim Pollock
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages