Revert "Defer NetworkHandler access in AlwaysOnVpnPreConnectUrlAllowlistService" [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Jun 18, 2026, 1:35:30 AM (9 days ago) Jun 18
to James Cook, Chromium LUCI CQ, Andreea Costinas, chromium...@chromium.org, Nikhil Nayunigari

Mitsuru Oshima has uploaded the change for review

Mitsuru Oshima would like James Cook, Chromium LUCI CQ and Andreea Costinas to review this change.

Commit message

Revert "Defer NetworkHandler access in AlwaysOnVpnPreConnectUrlAllowlistService"

This reverts commit a2a787ace644f5899843ea1bfe90aea769432e33.

Reason for revert: There is no dump report created by crrev.com/c/7799856 in 149, There is still a very few (9) in 150, and it will be investigated separately.

Original change's description:
> Defer NetworkHandler access in AlwaysOnVpnPreConnectUrlAllowlistService
>
> This CL fixes a crash occurring during profile initialization when
> AlwaysOnVpnPreConnectUrlAllowlistService is instantiated before
> ash::NetworkHandler has been initialized.
>
> Bug: 501330749
> Test: browser_tests --gtest_filter=AlwaysOnVpnPreConnectUrlAllowlistServiceTest.*
> Change-Id: Id08baa71e212a0d9d4c732bfbac2cc62686ad322
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7768231
> Reviewed-by: James Cook <jame...@chromium.org>
> Commit-Queue: Andreea Costinas <acos...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1618028}
Bug: 501330749
Change-Id: I958decc5f26f0bf2884d8331245c19063dad125b

Change diff


Change information

Files:
  • M chrome/browser/ash/net/alwayson_vpn_pre_connect_url_allowlist_service.cc
  • M chrome/browser/ash/net/alwayson_vpn_pre_connect_url_allowlist_service.h
Change size: S
Delta: 2 files changed, 3 insertions(+), 28 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I958decc5f26f0bf2884d8331245c19063dad125b
Gerrit-Change-Number: 7961637
Gerrit-PatchSet: 1
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Andreea Costinas <acos...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Jun 18, 2026, 2:01:18 AM (9 days ago) Jun 18
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, James Cook, Chromium LUCI CQ, Andreea Costinas, chromium...@chromium.org, Nikhil Nayunigari, net-r...@chromium.org, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, stevenjb+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org
Attention needed from Andreea Costinas and James Cook

Mitsuru Oshima voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andreea Costinas
  • James Cook
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I958decc5f26f0bf2884d8331245c19063dad125b
Gerrit-Change-Number: 7961637
Gerrit-PatchSet: 2
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Andreea Costinas <acos...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-Attention: James Cook <jame...@chromium.org>
Gerrit-Attention: Andreea Costinas <acos...@google.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 06:00:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 18, 2026, 2:01:27 AM (9 days ago) Jun 18
to Mitsuru Oshima, android-bu...@system.gserviceaccount.com, James Cook, Chromium LUCI CQ, Andreea Costinas, chromium...@chromium.org, Nikhil Nayunigari, net-r...@chromium.org, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, stevenjb+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org
Attention needed from Andreea Costinas and James Cook

Message from rubber-...@appspot.gserviceaccount.com

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Gerrit-Comment-Date: Thu, 18 Jun 2026 06:01:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andreea Costinas (Gerrit)

unread,
Jun 18, 2026, 6:46:13 AM (8 days ago) Jun 18
to Mitsuru Oshima, android-bu...@system.gserviceaccount.com, James Cook, Chromium LUCI CQ, chromium...@chromium.org, Nikhil Nayunigari, net-r...@chromium.org, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, stevenjb+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org
Attention needed from James Cook and Mitsuru Oshima

Andreea Costinas voted and added 1 comment

Votes added by Andreea Costinas

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Andreea Costinas . resolved

Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • James Cook
  • Mitsuru Oshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I958decc5f26f0bf2884d8331245c19063dad125b
    Gerrit-Change-Number: 7961637
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Andreea Costinas <acos...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 10:45:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Jun 18, 2026, 5:55:31 PM (8 days ago) Jun 18
    to Andreea Costinas, android-bu...@system.gserviceaccount.com, James Cook, Chromium LUCI CQ, chromium...@chromium.org, Nikhil Nayunigari, net-r...@chromium.org, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, stevenjb+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org
    Attention needed from James Cook

    Mitsuru Oshima voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • James Cook
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I958decc5f26f0bf2884d8331245c19063dad125b
    Gerrit-Change-Number: 7961637
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Andreea Costinas <acos...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-Attention: James Cook <jame...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 21:55:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 18, 2026, 5:58:29 PM (8 days ago) Jun 18
    to Mitsuru Oshima, Andreea Costinas, android-bu...@system.gserviceaccount.com, James Cook, chromium...@chromium.org, Nikhil Nayunigari, net-r...@chromium.org, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, stevenjb+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Defer NetworkHandler access in AlwaysOnVpnPreConnectUrlAllowlistService"

    This reverts commit a2a787ace644f5899843ea1bfe90aea769432e33.

    Reason for revert: There is no dump report created by crrev.com/c/7799856 in 149, There is still a very few (9) in 150, and it will be investigated separately.

    Original change's description:
    > Defer NetworkHandler access in AlwaysOnVpnPreConnectUrlAllowlistService
    >
    > This CL fixes a crash occurring during profile initialization when
    > AlwaysOnVpnPreConnectUrlAllowlistService is instantiated before
    > ash::NetworkHandler has been initialized.
    >
    > Bug: 501330749
    > Test: browser_tests --gtest_filter=AlwaysOnVpnPreConnectUrlAllowlistServiceTest.*
    > Change-Id: Id08baa71e212a0d9d4c732bfbac2cc62686ad322
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7768231
    > Reviewed-by: James Cook <jame...@chromium.org>
    > Commit-Queue: Andreea Costinas <acos...@google.com>
    > Cr-Commit-Position: refs/heads/main@{#1618028}
    Bug: 501330749
    Change-Id: I958decc5f26f0bf2884d8331245c19063dad125b
    Reviewed-by: Andreea Costinas <acos...@google.com>
    Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1649333}
    Files:
    • M chrome/browser/ash/net/alwayson_vpn_pre_connect_url_allowlist_service.cc
    • M chrome/browser/ash/net/alwayson_vpn_pre_connect_url_allowlist_service.h
    Change size: S
    Delta: 2 files changed, 3 insertions(+), 28 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Andreea Costinas
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I958decc5f26f0bf2884d8331245c19063dad125b
    Gerrit-Change-Number: 7961637
    Gerrit-PatchSet: 3
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages