[TabBottomSheet] Define Glic Button and Add to 3-dot menu Icon row [chromium/src : main]

0 views
Skip to first unread message

Calder Kitagawa (Gerrit)

unread,
4:00 PM (7 hours ago) 4:00 PM
to Bhuvana Betini, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Bhuvana Betini

Calder Kitagawa added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
Line 234, Patchset 1 (Latest): iconModels.add(buildPageInfoModel(currentTab));
Calder Kitagawa . unresolved

What happens to PageInfo? We still need an entry point for this. Is this just temporary

Open in Gerrit

Related details

Attention is currently required from:
  • Bhuvana Betini
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia85a0ae72abb8a7cff20a460807be285ce663d9d
Gerrit-Change-Number: 7474125
Gerrit-PatchSet: 1
Gerrit-Owner: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Attention: Bhuvana Betini <bbe...@google.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 21:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Calder Kitagawa (Gerrit)

unread,
4:02 PM (7 hours ago) 4:02 PM
to Bhuvana Betini, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Bhuvana Betini

Calder Kitagawa voted and added 1 comment

Votes added by Calder Kitagawa

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Calder Kitagawa . resolved

LGTM with question

Open in Gerrit

Related details

Attention is currently required from:
  • Bhuvana Betini
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia85a0ae72abb8a7cff20a460807be285ce663d9d
Gerrit-Change-Number: 7474125
Gerrit-PatchSet: 1
Gerrit-Owner: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Attention: Bhuvana Betini <bbe...@google.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 21:02:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bhuvana Betini (Gerrit)

unread,
5:06 PM (6 hours ago) 5:06 PM
to Hailey Wang, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Calder Kitagawa and Hailey Wang

Bhuvana Betini added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
Line 234, Patchset 1: iconModels.add(buildPageInfoModel(currentTab));
Calder Kitagawa . unresolved

What happens to PageInfo? We still need an entry point for this. Is this just temporary

Bhuvana Betini

According to the mocks, the glic button should replace the Page Info button (https://docs.google.com/presentation/d/13yIIm6GQVTgkwgnSoWkUJdL4QGmD3J2cWG4LxDBPTfA/edit?usp=sharing&resourcekey=0-xTN2w8VHviGrusQcL6MTgQ, Slide 11). This is because the Icon row can have a maximum of 5 icons. In the future, we can add more specific conditions of when this replacement should happen (b/475592540)

Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
  • Hailey Wang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia85a0ae72abb8a7cff20a460807be285ce663d9d
Gerrit-Change-Number: 7474125
Gerrit-PatchSet: 2
Gerrit-Owner: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Hailey Wang <haile...@google.com>
Gerrit-Attention: Hailey Wang <haile...@google.com>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 22:06:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Calder Kitagawa <ckit...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Hailey Wang (Gerrit)

unread,
7:43 PM (4 hours ago) 7:43 PM
to Bhuvana Betini, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Bhuvana Betini and Calder Kitagawa

Hailey Wang added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
Line 234, Patchset 1: iconModels.add(buildPageInfoModel(currentTab));
Calder Kitagawa . unresolved

What happens to PageInfo? We still need an entry point for this. Is this just temporary

Bhuvana Betini

According to the mocks, the glic button should replace the Page Info button (https://docs.google.com/presentation/d/13yIIm6GQVTgkwgnSoWkUJdL4QGmD3J2cWG4LxDBPTfA/edit?usp=sharing&resourcekey=0-xTN2w8VHviGrusQcL6MTgQ, Slide 11). This is because the Icon row can have a maximum of 5 icons. In the future, we can add more specific conditions of when this replacement should happen (b/475592540)

Hailey Wang

Yes this is temporary and done according to very early stage mock. Will modify accordingly once mocks are finalized, adding the button will facilitate testing glic.

Alternatively we could also gate it using glic buildflag added here: https://chromium-review.googlesource.com/c/chromium/src/+/7271409

Open in Gerrit

Related details

Attention is currently required from:
  • Bhuvana Betini
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia85a0ae72abb8a7cff20a460807be285ce663d9d
Gerrit-Change-Number: 7474125
Gerrit-PatchSet: 2
Gerrit-Owner: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Bhuvana Betini <bbe...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Hailey Wang <haile...@google.com>
Gerrit-Attention: Bhuvana Betini <bbe...@google.com>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 00:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bhuvana Betini <bbe...@google.com>
Comment-In-Reply-To: Calder Kitagawa <ckit...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Hailey Wang (Gerrit)

unread,
7:45 PM (4 hours ago) 7:45 PM
to Bhuvana Betini, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Bhuvana Betini and Calder Kitagawa

Hailey Wang added 1 comment

File chrome/browser/ui/android/strings/android_chrome_strings.grd
Line 2855, Patchset 2 (Latest): Ask glic
Hailey Wang . unresolved

Are you not planning on reusing desktop strings?

Gerrit-Comment-Date: Thu, 15 Jan 2026 00:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages