Remove IsLoaded check in IsAccessAllowed for style images [chromium/src : main]
0 views
Skip to first unread message
Stephen Chenney (Gerrit)
Jan 31, 2026, 9:03:04 AM (7 days ago) Jan 31
to Stefan Zager, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager
Stephen Chenney added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Feb 3, 2026, 10:36:04 AM (4 days ago) Feb 3
to Stephen Chenney, Stefan Zager, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager and Stephen Chenney
Philip Rogers added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Stefan Zager
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stefan Zager (Gerrit)
Feb 3, 2026, 11:41:09 AM (4 days ago) Feb 3
to Stephen Chenney, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stephen Chenney
Stefan Zager added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/style/style_fetched_image.cc
Line 124, Patchset 1 (Parent):
DCHECK(image_->IsLoaded());Stefan Zager . unresolved
Can this be:
`CHECK(image_->IsLoaded() || !image_->IsSVGImage());`
?
Related details
Attention is currently required from:
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Chenney (Gerrit)
Feb 3, 2026, 12:44:12 PM (4 days ago) Feb 3
to Philip Rogers, Stefan Zager, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager
Stephen Chenney added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/style/style_fetched_image.cc
Line 124, Patchset 1 (Parent):
DCHECK(image_->IsLoaded());Stefan Zager . unresolved
Can this be:
`CHECK(image_->IsLoaded() || !image_->IsSVGImage());`
?
Stephen Chenney
How about this change? I see the point of needing all the SVG to look at sub-resources/elements..
Related details
Attention is currently required from:
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stefan Zager (Gerrit)
Feb 6, 2026, 1:19:10 PM (23 hours ago) Feb 6
to Stephen Chenney, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stephen Chenney
Stefan Zager voted and added 2 comments![]( "Open in Gerrit")
Votes added by Stefan Zager
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/core/style/style_fetched_image.cc
Line 124, Patchset 1 (Parent):
DCHECK(image_->IsLoaded());Stefan Zager . resolved
Stephen ChenneyCan this be:
`CHECK(image_->IsLoaded() || !image_->IsSVGImage());`
?
How about this change? I see the point of needing all the SVG to look at sub-resources/elements..
Stefan Zager
It's not clear to me whether it's valid to call this method with a not-fully-loaded SVG image, but I guess we can punt on that.
Related details
Attention is currently required from:
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Chenney (Gerrit)
9:27 AM (3 hours ago) 9:27 AM
to Stefan Zager, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Stephen Chenney voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:19 AM (2 hours ago) 10:19 AM
to Stephen Chenney, Stefan Zager, Philip Rogers, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove IsLoaded check in IsAccessAllowed for style images
The check causes problem with progressively loaded content.
Access only depends on the URL, not the image content, so we
do not need it loaded.
Bug: 477643905
Change-Id: I6b1f669370b36b357e3226835330292899db4271
Reviewed-by: Stefan Zager <sza...@chromium.org>
Commit-Queue: Stephen Chenney <sche...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581346}
Files:
- M third_party/blink/renderer/core/paint/box_painter_base.cc
- M third_party/blink/renderer/core/paint/inline_box_fragment_painter.cc
- M third_party/blink/renderer/core/style/style_crossfade_image.cc
- M third_party/blink/renderer/core/style/style_fetched_image.cc
Change size: S
Delta: 4 files changed, 11 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Stefan Zager
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages