Expose RunLoop::RunUntilIdle to Rust [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
12:45 PM (4 hours ago) 12:45 PM
to Devon Loehr, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Devon Loehr
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 1 (Latest):
haven't processed the messages at that point.Daniel Cheng . unresolved
Can we just post a task to quit the run loop, or do we really need to ensure the run loop is empty and not just "all tasks before this quit closure was posted have run"?
Related details
Attention is currently required from:
- Devon Loehr
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devon Loehr (Gerrit)
12:57 PM (4 hours ago) 12:57 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Daniel Cheng
Devon Loehr added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 1 (Latest):
haven't processed the messages at that point.Daniel Cheng . unresolved
Can we just post a task to quit the run loop, or do we really need to ensure the run loop is empty and not just "all tasks before this quit closure was posted have run"?
Devon Loehr
The problem is that the tasks will themselves post future tasks (e.g. to handle the response).
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
2:22 PM (3 hours ago) 2:22 PM
to Devon Loehr, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Devon Loehr
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Daniel Cheng . resolved
LGTM
I mean, not really, but it's not worse and it seems unavoidable so shrug :)
Related details
Attention is currently required from:
- Devon Loehr
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devon Loehr (Gerrit)
2:40 PM (2 hours ago) 2:40 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org
Devon Loehr added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 1 (Latest):
haven't processed the messages at that point.Daniel Cheng . resolved
Devon LoehrCan we just post a task to quit the run loop, or do we really need to ensure the run loop is empty and not just "all tasks before this quit closure was posted have run"?
The problem is that the tasks will themselves post future tasks (e.g. to handle the response).
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devon Loehr (Gerrit)
3:36 PM (1 hour ago) 3:36 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org
Devon Loehr voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:42 PM (1 hour ago) 3:42 PM
to Devon Loehr, Daniel Cheng, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Expose RunLoop::RunUntilIdle to Rust
Previously we avoided exposing this because it's easy to misuse.
However, when testing associated interfaces we really need it,
because we need to ensure that messages _aren't_ processed while
blocked by a pending event, and the only way we can ensure that is
to run through all tasks until we run out, and then check that we
haven't processed the messages at that point.
Bug: 493274453
Change-Id: I236c4b4ff50c0bce790eb91af3dfc536f1059e8b
Commit-Queue: Devon Loehr <dlo...@google.com>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637885}
Files:
- M base/run_loop.rs
- M base/run_loop_rust_shim.cc
- M base/run_loop_rust_shim.h
Change size: S
Delta: 3 files changed, 28 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages