[omnibox] Fix dimensions and alignment for Full WebUI popup. [chromium/src : main]

0 views
Skip to first unread message

Paul Adedeji (Gerrit)

unread,
May 27, 2026, 6:34:38 PM (22 hours ago) May 27
to Aviv Kiss, Chromium LUCI CQ, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Aviv Kiss

Paul Adedeji voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aviv Kiss
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0501c3eb6aeee62829956b1b604a35acb879222a
Gerrit-Change-Number: 7877259
Gerrit-PatchSet: 8
Gerrit-Owner: Paul Adedeji <paula...@google.com>
Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
Gerrit-Attention: Aviv Kiss <aviv...@google.com>
Gerrit-Comment-Date: Wed, 27 May 2026 22:34:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Aviv Kiss (Gerrit)

unread,
9:07 AM (8 hours ago) 9:07 AM
to Paul Adedeji, Chromium LUCI CQ, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Paul Adedeji

Aviv Kiss voted and added 1 comment

Votes added by Aviv Kiss

Code-Review+1

1 comment

File chrome/browser/ui/views/omnibox/omnibox_popup_presenter_base.cc
Line 257, Patchset 8 (Latest): if (ShouldTrustContentHeight()) {
Aviv Kiss . unresolved

nit: maybe we should name this ShouldUseWebContentHeight?

Open in Gerrit

Related details

Attention is currently required from:
  • Paul Adedeji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0501c3eb6aeee62829956b1b604a35acb879222a
    Gerrit-Change-Number: 7877259
    Gerrit-PatchSet: 8
    Gerrit-Owner: Paul Adedeji <paula...@google.com>
    Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
    Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
    Gerrit-Attention: Paul Adedeji <paula...@google.com>
    Gerrit-Comment-Date: Thu, 28 May 2026 13:07:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Paul Adedeji (Gerrit)

    unread,
    12:11 PM (5 hours ago) 12:11 PM
    to Aviv Kiss, Chromium LUCI CQ, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

    Paul Adedeji added 1 comment

    File chrome/browser/ui/views/omnibox/omnibox_popup_presenter_base.cc
    Line 257, Patchset 8: if (ShouldTrustContentHeight()) {
    Aviv Kiss . resolved

    nit: maybe we should name this ShouldUseWebContentHeight?

    Paul Adedeji

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0501c3eb6aeee62829956b1b604a35acb879222a
      Gerrit-Change-Number: 7877259
      Gerrit-PatchSet: 9
      Gerrit-Owner: Paul Adedeji <paula...@google.com>
      Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
      Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
      Gerrit-Comment-Date: Thu, 28 May 2026 16:11:47 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Aviv Kiss <aviv...@google.com>
      satisfied_requirement
      open
      diffy

      Paul Adedeji (Gerrit)

      unread,
      3:41 PM (1 hour ago) 3:41 PM
      to Aviv Kiss, Chromium LUCI CQ, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

      Paul Adedeji voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0501c3eb6aeee62829956b1b604a35acb879222a
      Gerrit-Change-Number: 7877259
      Gerrit-PatchSet: 11
      Gerrit-Owner: Paul Adedeji <paula...@google.com>
      Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
      Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
      Gerrit-Comment-Date: Thu, 28 May 2026 19:41:11 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages