Revert "Remove stale WebGL 1 expectations" [chromium/src : main]

0 views
Skip to first unread message

Jonathan Lee (Gerrit)

unread,
6:16 PM (2 hours ago) 6:16 PM
to chrome-automat...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, Rubber Stamper, chromium...@chromium.org

Jonathan Lee has uploaded the change for review

Jonathan Lee would like chrome-automat...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ and Rubber Stamper to review this change.

Commit message

Revert "Remove stale WebGL 1 expectations"

This reverts commit 084a50c9ac9cad9cae3615954207d8957ea5b039.

Reason for revert: Flakiness due to expectation too narrow:
  https://ci.chromium.org/ui/test/chromium/%3A%2F%2Fchrome%2Ftest%5C%3Atelemetry_gpu_integration_test_android_chrome!flat%3A%3A%23gpu_tests.webgl1_conformance_integration_test.WebGL1ConformanceIntegrationTest.conformance%2Fextensions%2Foes-element-index-uint.html?q=V%3Abuilder%3DAndroid%2520FYI%2520Experimental%2520Release%2520%28Pixel%25206%29+V%3Adevice_os%3DAP1A.240405.002+V%3Adevice_type%3Doriole+V%3Aos%3DAndroid+V%3Atest_suite%3Dwebgl_conformance_validating_ganesh_tests

Original change's description:
> Remove stale WebGL 1 expectations
>
> Autogenerated CL from running:
>
> //content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl1_conformance
>
> Affected bugs for CL description:
>
> R=rubber-...@appspot.gserviceaccount.com
>
> Bug: 465162387
> Change-Id: Id3e58cff6f1f0f34e8e7727dde844213b7e1d645
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7243585
> Auto-Submit: chrome-automat...@chops-service-accounts.iam.gserviceaccount.com <chrome-automat...@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1556561}
Bug: 465162387
Change-Id: Ic426fd146872652670b1211d3901f9800b53f5a8

Change diff

diff --git a/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt b/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
index 7dbbe2d..2f89e26 100644
--- a/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
+++ b/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
@@ -575,7 +575,7 @@
 crbug.com/1288590 [ android android-pixel-6 ] conformance/misc/shader-precision-format.html [ Failure ]
 crbug.com/1288603 [ android android-pixel-6 passthrough angle-opengles ] conformance/extensions/angle-instanced-arrays-out-of-bounds.html [ Failure ]
 crbug.com/40236526 [ android android-pixel-6 no-passthrough ] conformance/rendering/blending.html [ Failure ]
-crbug.com/465162387 [ android android-pixel-6 angle-opengles graphite-enabled passthrough renderer-skia-gl ] conformance/extensions/oes-element-index-uint.html [ Failure ]
+crbug.com/465162387 [ android android-pixel-6 ] conformance/extensions/oes-element-index-uint.html [ Failure ]
 
 ## Pixel 10 ##

Change information

Files:
  • M content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic426fd146872652670b1211d3901f9800b53f5a8
Gerrit-Change-Number: 7488231
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Jonathan Lee (Gerrit)

unread,
6:16 PM (2 hours ago) 6:16 PM
to chrome-automat...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, Rubber Stamper, chromium...@chromium.org

Jonathan Lee voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic426fd146872652670b1211d3901f9800b53f5a8
Gerrit-Change-Number: 7488231
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-Comment-Date: Thu, 15 Jan 2026 23:16:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
6:17 PM (2 hours ago) 6:17 PM
to Jonathan Lee, chrome-automat...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic426fd146872652670b1211d3901f9800b53f5a8
    Gerrit-Change-Number: 7488231
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jonathan Lee <jonath...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:17:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Brian Sheedy (Gerrit)

    unread,
    6:26 PM (2 hours ago) 6:26 PM
    to Jonathan Lee, Yuly Novikov, Rubber Stamper, chrome-automat...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Jonathan Lee

    Brian Sheedy voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jonathan Lee
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic426fd146872652670b1211d3901f9800b53f5a8
    Gerrit-Change-Number: 7488231
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jonathan Lee <jonath...@google.com>
    Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
    Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
    Gerrit-Attention: Jonathan Lee <jonath...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:26:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    7:40 PM (1 hour ago) 7:40 PM
    to Jonathan Lee, Brian Sheedy, Yuly Novikov, Rubber Stamper, chrome-automat...@chops-service-accounts.iam.gserviceaccount.com, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Remove stale WebGL 1 expectations"

    This reverts commit 084a50c9ac9cad9cae3615954207d8957ea5b039.

    Reason for revert: Flakiness due to expectation too narrow:
      https://ci.chromium.org/ui/test/chromium/%3A%2F%2Fchrome%2Ftest%5C%3Atelemetry_gpu_integration_test_android_chrome!flat%3A%3A%23gpu_tests.webgl1_conformance_integration_test.WebGL1ConformanceIntegrationTest.conformance%2Fextensions%2Foes-element-index-uint.html?q=V%3Abuilder%3DAndroid%2520FYI%2520Experimental%2520Release%2520%28Pixel%25206%29+V%3Adevice_os%3DAP1A.240405.002+V%3Adevice_type%3Doriole+V%3Aos%3DAndroid+V%3Atest_suite%3Dwebgl_conformance_validating_ganesh_tests

    Original change's description:
    > Remove stale WebGL 1 expectations
    >
    > Autogenerated CL from running:
    >
    > //content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl1_conformance
    >
    > Affected bugs for CL description:
    >
    > R=rubber-...@appspot.gserviceaccount.com
    >
    > Bug: 465162387
    > Change-Id: Id3e58cff6f1f0f34e8e7727dde844213b7e1d645
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7243585
    > Auto-Submit: chrome-automat...@chops-service-accounts.iam.gserviceaccount.com <chrome-automat...@chops-service-accounts.iam.gserviceaccount.com>
    > Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    > Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    > Cr-Commit-Position: refs/heads/main@{#1556561}
    Bug: 465162387
    Change-Id: Ic426fd146872652670b1211d3901f9800b53f5a8
    Commit-Queue: Brian Sheedy <bsh...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Reviewed-by: Brian Sheedy <bsh...@chromium.org>
    Auto-Submit: Jonathan Lee <jonath...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1570094}
    Files:
    • M content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brian Sheedy, Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic426fd146872652670b1211d3901f9800b53f5a8
    Gerrit-Change-Number: 7488231
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages