Clean up: Fix 28 wrong escapes in 15 DEPS files in ash [chromium/src : main]

0 views
Skip to first unread message

Yoshiki IGUCHI (Gerrit)

unread,
May 29, 2026, 5:20:02 PM (2 days ago) May 29
to Yoshiki IGUCHI, Hidehiko Abe, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Chromium LUCI CQ, abigailbk...@google.com, byronle...@chromium.org, chungshe...@google.com, croissant-...@chromium.org, dennyh...@google.com, dtseng...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, hirokisa...@chromium.org, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, menghua...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, nektar...@chromium.org, shend...@chromium.org, tranbaod...@chromium.org, wangdanny+watch-in...@google.com, weiluanw...@google.com, yhanada...@chromium.org, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com
Attention needed from Hidehiko Abe

Yoshiki IGUCHI added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yoshiki IGUCHI . resolved

Hidehiko-san, PTAL. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idf2111cd2a378038fff7ed40f9add53b29e5047f
Gerrit-Change-Number: 7885516
Gerrit-PatchSet: 2
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Di Wu <di...@google.com>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Fri, 29 May 2026 21:19:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
May 31, 2026, 10:32:23 PM (2 hours ago) May 31
to Yoshiki IGUCHI, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Chromium LUCI CQ, abigailbk...@google.com, byronle...@chromium.org, chungshe...@google.com, croissant-...@chromium.org, dennyh...@google.com, dtseng...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, hirokisa...@chromium.org, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, menghua...@google.com, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, nektar...@chromium.org, shend...@chromium.org, tranbaod...@chromium.org, wangdanny+watch-in...@google.com, weiluanw...@google.com, yhanada...@chromium.org, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com
Attention needed from Yoshiki IGUCHI

Hidehiko Abe voted and added 7 comments

Votes added by Hidehiko Abe

Code-Review+1

7 comments

Patchset-level comments
Hidehiko Abe . resolved

LGTM with comments. Thank you for clean up.

File ash/DEPS
Line 184, Patchset 2 (Latest): "policy_recommendation_restorer_unittest.cc": [
Hidehiko Abe . unresolved

nit: `\\.` too?

Line 190, Patchset 2 (Latest): "shell.cc": [
Hidehiko Abe . unresolved

ditto

Line 194, Patchset 2 (Latest): "window_manager.cc": [
Hidehiko Abe . unresolved

ditto

File ash/ambient/DEPS
Line 16, Patchset 2 (Latest): ".*test.cc": [
Hidehiko Abe . unresolved

`.*test\\.cc`?

File ash/webui/graduation/DEPS
Line 6, Patchset 2 (Latest): "graduation_ui_handler.cc": [
Hidehiko Abe . unresolved

ditto

Line 14, Patchset 2 (Latest): "webview_auth_handler_unittest.cc": [
Hidehiko Abe . unresolved

ditto

Open in Gerrit

Related details

Attention is currently required from:
  • Yoshiki IGUCHI
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idf2111cd2a378038fff7ed40f9add53b29e5047f
Gerrit-Change-Number: 7885516
Gerrit-PatchSet: 2
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Di Wu <di...@google.com>
Gerrit-Attention: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 02:31:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages