[contextual_tasks] Hide underlines when clearing out a tab chip [chromium/src : main]
0 views
Skip to first unread message
Shakti Sahu (Gerrit)
Jan 16, 2026, 10:45:51 PM (14 hours ago) Jan 16
to Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Sophie Chang
Shakti Sahu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
12:42 AM (12 hours ago) 12:42 AM
to Shakti Sahu, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Sophie Chang
Attention needed from Shakti Sahu
Min Qin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Shakti Sahu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shakti Sahu (Gerrit)
11:56 AM (1 hour ago) 11:56 AM
to Min Qin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Sophie Chang
Shakti Sahu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:41 PM (5 minutes ago) 12:41 PM
to Shakti Sahu, Min Qin, AyeAye, chromium...@chromium.org, Sophie Chang
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[contextual_tasks] Hide underlines when clearing out a tab chip
This CL hides underlines when a tab chip is cleard on the composebox.
This was recently broken by
https://chromium-review.googlesource.com/c/chromium/src/+/7404206
which removes the tab disassociation logic when a chip is cleared.
After this CL, tab chip when removed still keeps the association, but
will hide the underline.
Bug: b:476523954
Change-Id: If01c8529350ad0a430d23b12aff3ce4c7e988c88
Commit-Queue: Shakti Sahu <shakt...@chromium.org>
Reviewed-by: Min Qin <qin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1570804}
Files:
- M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler.cc
Change size: S
Delta: 1 file changed, 17 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Min Qin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages