3pp: limit the concurrency for compiling pyc to 4 [infra/luci/luci-go : main]
0 views
Skip to first unread message
Chenlin Fan (Gerrit)
12:44 AM (23 hours ago) 12:44 AM
to Brian Sheedy, Tricium, LUCI CQ, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Brian Sheedy
Chenlin Fan voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brian Sheedy
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Sheedy (Gerrit)
1:31 PM (10 hours ago) 1:31 PM
to Chenlin Fan, Tricium, LUCI CQ, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Chenlin Fan
Brian Sheedy voted and added 2 comments![]( "Open in Gerrit")
Votes added by Brian Sheedy
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Brian Sheedy . resolved
Stamping to unblock submission since there's a good chance I'll be done for the day by the time you're back, but please adjust the limit before submitting.
File vpython/python/bootstrap.py
Line 24, Patchset 2 (Latest):
COMPILE_WORKERS = min(os.cpu_count() or 1, 4) # Limit the concurrency to 4Brian Sheedy . unresolved
As mentioned in chat, a limit of 32 seems to resolve the issue while also being less restrictive for other (unaffected) configurations, so let's go with that instead.
Related details
Attention is currently required from:
- Chenlin Fan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Sheedy (Gerrit)
9:10 PM (3 hours ago) 9:10 PM
to Chenlin Fan, Tricium, LUCI CQ, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Chenlin Fan
Brian Sheedy added 1 comment![]( "Open in Gerrit")
File vpython/python/bootstrap.py
Line 24, Patchset 2 (Latest):
COMPILE_WORKERS = min(os.cpu_count() or 1, 4) # Limit the concurrency to 4Brian Sheedy . resolved
As mentioned in chat, a limit of 32 seems to resolve the issue while also being less restrictive for other (unaffected) configurations, so let's go with that instead.
Brian Sheedy
Discussed offline, 4 is fine.
Related details
Attention is currently required from:
- Chenlin Fan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Sheedy (Gerrit)
9:10 PM (3 hours ago) 9:10 PM
to Chenlin Fan, Tricium, LUCI CQ, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Chenlin Fan
Brian Sheedy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Chenlin Fan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages