this.toggleStartAnimation_ = !this.toggleStartAnimation_;Can we expose a "restartAnimation()" function in composebox instead? Similar to clearInputAndFocus() below?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
void this.$.opaqueOverlay.offsetWidth;Can you add a comment explaining what you are doing with this line? Why is it necessary?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
this.toggleStartAnimation_ = !this.toggleStartAnimation_;Can we expose a "restartAnimation()" function in composebox instead? Similar to clearInputAndFocus() below?
Done
this.toggleStartAnimation_ = !this.toggleStartAnimation_;Can we expose a "restartAnimation()" function in composebox instead? Similar to clearInputAndFocus() below?
Done
void this.$.opaqueOverlay.offsetWidth;Can you add a comment explaining what you are doing with this line? Why is it necessary?
Done
void this.$.opaqueOverlay.offsetWidth;Can you add a comment explaining what you are doing with this line? Why is it necessary?
Done
reflect: true,does this need to reflect?
nope, removed
reflect: true,does this need to reflect?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
if (!ui_service_->IsAiUrl(url)) {
return;
}remove
this.$.opaqueOverlay.classList.remove('fade-animation');
/* Requesting offsetWidth forces css re-render (synchronous reflow)
* since browser wants to be accurate awhen giving current measurement
* of offsetWidth. Otherwise, browser is lazy and considers adding
* then removing class as not a renderable css change.
*/
void this.$.opaqueOverlay.offsetWidth;
this.$.opaqueOverlay.classList.add('fade-animation');| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
if (!ui_service_->IsAiUrl(url)) {
return;
}James Leungremove
Done
this.$.opaqueOverlay.classList.remove('fade-animation');
/* Requesting offsetWidth forces css re-render (synchronous reflow)
* since browser wants to be accurate awhen giving current measurement
* of offsetWidth. Otherwise, browser is lazy and considers adding
* then removing class as not a renderable css change.
*/
void this.$.opaqueOverlay.offsetWidth;
this.$.opaqueOverlay.classList.add('fade-animation');| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
protected accessor isZeroState_: boolean = true;remove
/* Longer than usual delay in case there is lag in loading webview. */This should still be above right?
isFirstLoad: {Shoudl we replace isFirstLoad and use the startOverlayAnimation method directly in the connectedCallback?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
protected accessor isZeroState_: boolean = true;James Leungremove
Done
/* Longer than usual delay in case there is lag in loading webview. */This should still be above right?
Done
isFirstLoad: {Shoudl we replace isFirstLoad and use the startOverlayAnimation method directly in the connectedCallback?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[contexutal tasks] Various fixes for zero state
- correct right margin in side panel when shrinking/growing
- expand animation + overlay fade animation play when entering new thread
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |