[ios] Mark processes as sandboxed that aren't the browser [chromium/src : main]
Will Harris (Gerrit)
Will Harris added 1 comment![]( "Open in Gerrit")
return !is_browser;does `Seatbelt::IsSandboxed` (aka `::sandbox_check`) not work on iOS?
Related details
- Dave Tapuska
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Dave Tapuska added 1 comment![]( "Open in Gerrit")
return !is_browser;does `Seatbelt::IsSandboxed` (aka `::sandbox_check`) not work on iOS?
No that isn't going to work. That API is not available for iOS.
Related details
- Will Harris
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will Harris (Gerrit)
Will Harris voted and added 1 comment![]( "Open in Gerrit")
Votes added by Will Harris
| Code-Review | +1 |
1 comment
return !is_browser;Dave Tapuskadoes `Seatbelt::IsSandboxed` (aka `::sandbox_check`) not work on iOS?
No that isn't going to work. That API is not available for iOS.
- Dave Tapuska
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Dave Tapuska voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[ios] Mark processes as sandboxed that aren't the browser
BrowserEngineKit sandboxes processes it launches so return
that anything that isn't the browser is sandboxed.
- M sandbox/policy/sandbox.cc
Code-Review: +1 by Will Harris
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5113083862188032
Sample build with failed test: https://ci.chromium.org/b/8708966394389317473
Affected test(s):
[ninja://content/test:content_browsertests/MojoSandboxTest.NotIsProcessSandboxed](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FMojoSandboxTest.NotIsProcessSandboxed?q=VHash%3Aa70550d9f332f1c1)
A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5113083862188032&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6771247&type=BUG
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |