Remove stray includes of ipc_message.h [chromium/src : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Oct 16, 2025, 6:49:15 PM (4 days ago) Oct 16
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Tom Sepez . resolved

+Daniel for +OO

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1f8359f371bcad1a1b231edcfa07dcadf0f68b1
Gerrit-Change-Number: 7029461
Gerrit-PatchSet: 6
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Oct 2025 22:49:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
12:29 PM (7 hours ago) 12:29 PM
to Tom Sepez, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Tom Sepez

Daniel Cheng voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1f8359f371bcad1a1b231edcfa07dcadf0f68b1
Gerrit-Change-Number: 7029461
Gerrit-PatchSet: 7
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 16:29:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
12:59 PM (7 hours ago) 12:59 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Tom Sepez voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1f8359f371bcad1a1b231edcfa07dcadf0f68b1
Gerrit-Change-Number: 7029461
Gerrit-PatchSet: 7
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 16:59:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
2:19 PM (6 hours ago) 2:19 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Gerrit-Comment-Date: Mon, 20 Oct 2025 18:19:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
2:26 PM (6 hours ago) 2:26 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Tom Sepez voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1f8359f371bcad1a1b231edcfa07dcadf0f68b1
Gerrit-Change-Number: 7029461
Gerrit-PatchSet: 8
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 18:25:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
3:35 PM (4 hours ago) 3:35 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Gerrit-Comment-Date: Mon, 20 Oct 2025 19:35:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
4:20 PM (4 hours ago) 4:20 PM
to Tom Sepez, Daniel Cheng, chromium...@chromium.org, chromotin...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Remove stray includes of ipc_message.h

Very few places need access to the IPC::Message type.
Bug: 40621529
Change-Id: Id1f8359f371bcad1a1b231edcfa07dcadf0f68b1
Commit-Queue: Tom Sepez <tse...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1532497}
Files:
  • M components/safe_browsing/content/browser/DEPS
  • M components/safe_browsing/core/browser/DEPS
  • M content/browser/renderer_host/agent_scheduling_group_host.cc
  • M content/browser/renderer_host/render_frame_host_delegate.cc
  • M content/browser/renderer_host/render_frame_proxy_host.cc
  • M content/public/browser/web_contents_observer.h
  • M content/renderer/render_frame_impl.h
  • M content/test/mock_agent_scheduling_group_host.h
  • M extensions/renderer/api/messaging/one_time_message_handler.cc
  • M extensions/renderer/api_activity_logger_unittest.cc
  • M ipc/handle_win.cc
  • M ipc/ipc_channel_unittest.cc
  • M ipc/ipc_message_pipe_reader.h
  • M ipc/ipc_mojo_message_helper.h
  • M ipc/ipc_perftest_util.h
  • M ipc/ipc_sync_channel.cc
  • M ipc/ipc_sync_channel_unittest.cc
  • M ipc/message_view.h
  • M ipc/param_traits_protobuf_utils_unittest.cc
  • M media/base/ipc/media_param_traits.h
  • M mojo/public/cpp/bindings/tests/test_native_types.cc
  • M mojo/public/cpp/bindings/tests/test_native_types.h
  • M remoting/host/ipc_desktop_environment_unittest.cc
  • M remoting/host/win/unprivileged_process_delegate.cc
  • M remoting/host/win/wts_session_process_delegate.cc
Change size: S
Delta: 25 files changed, 11 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1f8359f371bcad1a1b231edcfa07dcadf0f68b1
Gerrit-Change-Number: 7029461
Gerrit-PatchSet: 9
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages