[DownloadBubble] Do not show bubble automatically when observed by extensions. [chromium/src : main]
Xinghui Lu (Gerrit)
Attention is currently required from: Min Qin, Rohit Bhatia.
Patch set 5:Commit-Queue +1
To view, visit change 3814950. To unsubscribe, or for help writing mail filters, visit settings.
Rohit Bhatia (Gerrit)
Attention is currently required from: Min Qin, Xinghui Lu.
Patch set 6:Code-Review +1
Min Qin (Gerrit)
Attention is currently required from: Xinghui Lu.
Patch set 7:Code-Review +1
Xinghui Lu (Gerrit)
Attention is currently required from: Peter Boström.
1 comment:
Patchset:
+pbos@, could you review browser_close_unittest.cc? Thanks!
To view, visit change 3814950. To unsubscribe, or for help writing mail filters, visit settings.
Peter Boström (Gerrit)
Attention is currently required from: Xinghui Lu.
Patch set 8:Code-Review +1
1 comment:
Patchset:
browser_close_unittest.cc lgtm
To view, visit change 3814950. To unsubscribe, or for help writing mail filters, visit settings.
Xinghui Lu (Gerrit)
Attention is currently required from: Xinghui Lu.
Patch set 8:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[DownloadBubble] Do not show bubble automatically when observed by extensions.
When the extension bubble and the download bubble are shown at the
same time, they may overlap with each other (e.g.
http://screen/AjBcrA44qdeWhpK). In this CL, if download events are
observed by at least one extension, we no longer show the bubble
automatically when the download has started or completed. The
download bubble will still be shown if the user clicks the toolbar
button manually.
Bug: 1349532
Change-Id: I0cbc9d2ea879f790939273246f777843424d7719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814950
Reviewed-by: Rohit Bhatia <bhati...@google.com>
Reviewed-by: Min Qin <qin...@chromium.org>
Reviewed-by: Peter Boström <pb...@chromium.org>
Commit-Queue: Xinghui Lu <xing...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1034261}
---
M chrome/browser/download/bubble/download_bubble_prefs.cc
M chrome/browser/download/bubble/download_bubble_prefs.h
M chrome/browser/download/bubble/download_display_controller.cc
M chrome/browser/download/download_core_service.h
M chrome/browser/download/download_core_service_impl.cc
M chrome/browser/download/download_core_service_impl.h
M chrome/browser/extensions/api/downloads/downloads_api.cc
M chrome/browser/extensions/api/downloads/downloads_api.h
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
M chrome/browser/ui/browser_close_unittest.cc
10 files changed, 104 insertions(+), 17 deletions(-)