[auth] Don't mutate *RealmsCfg passed to ExpandRealms. [infra/luci/luci-go : main]
0 views
Skip to first unread message
Vadim Shtayura (Gerrit)
Apr 17, 2026, 4:41:55 PM (13 days ago) Apr 17
to Anne Redulla, chromium...@chromium.org
Attention needed from Anne Redulla
Vadim Shtayura voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Anne Redulla
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anne Redulla (Gerrit)
Apr 20, 2026, 9:14:05 PM (10 days ago) Apr 20
to Vadim Shtayura, infra-...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Attention needed from Vadim Shtayura
Anne Redulla voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Vadim Shtayura
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vadim Shtayura (Gerrit)
Apr 20, 2026, 10:30:39 PM (10 days ago) Apr 20
to Anne Redulla, infra-...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Vadim Shtayura voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
infra-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 20, 2026, 10:48:51 PM (10 days ago) Apr 20
to Vadim Shtayura, Anne Redulla, chromium...@chromium.org
infra-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[auth] Don't mutate *RealmsCfg passed to ExpandRealms.
I was confused by this when writing tests.
R=aredulla
BUG=b/503350251
Change-Id: If643d3ce3d952908b57ac31fc6a28c9ab5721a8b
Reviewed-by: Anne Redulla <ared...@google.com>
Commit-Queue: Vadim Shtayura <vad...@chromium.org>
Files:
- M auth_service/internal/realmsinternals/config.go
Change size: S
Delta: 1 file changed, 13 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anne Redulla
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages