[contextual_tasks] Add a type enum to UrlResource [chromium/src : main]
0 views
Skip to first unread message
Shakti Sahu (Gerrit)
Jan 16, 2026, 10:45:34 PM (14 hours ago) Jan 16
to chromium...@chromium.org, Sophie Chang
Shakti Sahu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
12:43 AM (12 hours ago) 12:43 AM
to Shakti Sahu, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Shakti Sahu
Min Qin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Shakti Sahu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shakti Sahu (Gerrit)
11:54 AM (1 hour ago) 11:54 AM
to Tommy Nyquist, Min Qin, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Tommy Nyquist
Shakti Sahu voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Tommy Nyquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:59 AM (1 hour ago) 11:59 AM
to Shakti Sahu, Tommy Nyquist, Min Qin, chromium...@chromium.org, Sophie Chang
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[contextual_tasks] Add a type enum to UrlResource
Since UrlResource and UrlAttachment are used by different types
of context (tabs, images, files etc), this CL introduces an
enum ResourceType. This also corresponds to the type of the
context received from the server side
(third_party/lens_server_proto/aim_communication.proto)
Bug: b:467166272
Change-Id: I13ec56ceabd46e7a69222610bdf835730283608c
Reviewed-by: Min Qin <qin...@chromium.org>
Commit-Queue: Shakti Sahu <shakt...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1570801}
Files:
- M chrome/browser/contextual_tasks/ai_mode_context_library_converter.cc
- M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler_unittest.cc
- M chrome/browser/contextual_tasks/contextual_tasks_page_handler.cc
- M components/contextual_tasks/internal/contextual_tasks_service_impl_unittest.cc
- M components/contextual_tasks/internal/pending_context_decorator.cc
- M components/contextual_tasks/public/contextual_task.cc
- M components/contextual_tasks/public/contextual_task.h
- M components/contextual_tasks/public/contextual_task_context.cc
- M components/contextual_tasks/public/contextual_task_context.h
- M components/contextual_tasks/public/contextual_task_unittest.cc
Change size: M
Delta: 10 files changed, 70 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Min Qin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages