Use PageEmbeddingsService in HistoryEmbeddingsService [chromium/src : main]

0 views
Skip to first unread message

Mike Wittman (Gerrit)

unread,
Feb 25, 2026, 5:42:54 PM (2 days ago) Feb 25
to Mike Wittman, Steven Holte, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Steven Holte

Mike Wittman voted and added 1 comment

Votes added by Mike Wittman

Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Steven Holte
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2ec408744154a7a39d6c21c7c30082df600bdcd0
Gerrit-Change-Number: 7549570
Gerrit-PatchSet: 31
Gerrit-Owner: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Steven Holte <ho...@chromium.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 22:42:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Steven Holte (Gerrit)

unread,
Feb 27, 2026, 5:28:24 PM (7 hours ago) Feb 27
to Mike Wittman, Steven Holte, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Mike Wittman

Steven Holte voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mike Wittman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2ec408744154a7a39d6c21c7c30082df600bdcd0
    Gerrit-Change-Number: 7549570
    Gerrit-PatchSet: 31
    Gerrit-Owner: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Mike Wittman <wit...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 22:28:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mike Wittman (Gerrit)

    unread,
    Feb 27, 2026, 9:45:51 PM (3 hours ago) Feb 27
    to Mike Wittman, Alex Moshchuk, Steven Holte, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
    Attention needed from Alex Moshchuk

    Mike Wittman added 1 comment

    Patchset-level comments
    File-level comment, Patchset 31:
    Mike Wittman . resolved

    +alexmos for +content/public/browser in components/history_embeddings/content/DEPS

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Moshchuk
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2ec408744154a7a39d6c21c7c30082df600bdcd0
    Gerrit-Change-Number: 7549570
    Gerrit-PatchSet: 31
    Gerrit-Owner: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Comment-Date: Sat, 28 Feb 2026 02:45:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages