[Peek View] Adds support for multi-task tracking in Peek View [chromium/src : main]

0 views
Skip to first unread message

Hailey Wang (Gerrit)

unread,
Jun 17, 2026, 11:29:13 PM (6 days ago) Jun 17
to Siddhartha S, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Siddhartha S

Hailey Wang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Siddhartha S
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I775734e0b1536311d93cd001ba37aef7475fb851
Gerrit-Change-Number: 7960601
Gerrit-PatchSet: 3
Gerrit-Owner: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: Hailey Wang <haile...@google.com>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
Gerrit-Attention: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 03:29:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hailey Wang (Gerrit)

unread,
Jun 17, 2026, 11:29:22 PM (6 days ago) Jun 17
to Siddhartha S, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Siddhartha S

Hailey Wang voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Siddhartha S
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I775734e0b1536311d93cd001ba37aef7475fb851
    Gerrit-Change-Number: 7960601
    Gerrit-PatchSet: 3
    Gerrit-Owner: Siddhartha S <ss...@chromium.org>
    Gerrit-Reviewer: Hailey Wang <haile...@google.com>
    Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
    Gerrit-Attention: Siddhartha S <ss...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 03:29:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hailey Wang (Gerrit)

    unread,
    Jun 18, 2026, 12:04:28 AM (6 days ago) Jun 18
    to Siddhartha S, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, dewitt...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Siddhartha S

    Hailey Wang voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Siddhartha S
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I775734e0b1536311d93cd001ba37aef7475fb851
      Gerrit-Change-Number: 7960601
      Gerrit-PatchSet: 4
      Gerrit-Owner: Siddhartha S <ss...@chromium.org>
      Gerrit-Reviewer: Hailey Wang <haile...@google.com>
      Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
      Gerrit-Attention: Siddhartha S <ss...@chromium.org>
      Gerrit-Comment-Date: Thu, 18 Jun 2026 04:04:16 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Siddhartha S (Gerrit)

      unread,
      Jun 18, 2026, 12:20:50 AM (6 days ago) Jun 18
      to Siddhartha S, Hailey Wang, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, dewitt...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Hailey Wang

      Siddhartha S voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hailey Wang
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I775734e0b1536311d93cd001ba37aef7475fb851
        Gerrit-Change-Number: 7960601
        Gerrit-PatchSet: 5
        Gerrit-Owner: Siddhartha S <ss...@chromium.org>
        Gerrit-Reviewer: Hailey Wang <haile...@google.com>
        Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
        Gerrit-Attention: Hailey Wang <haile...@google.com>
        Gerrit-Comment-Date: Thu, 18 Jun 2026 04:20:35 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Wenyu Fu (Gerrit)

        unread,
        Jun 18, 2026, 12:55:51 AM (6 days ago) Jun 18
        to Siddhartha S, Hailey Wang, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, dewitt...@chromium.org, mfoltz+wa...@chromium.org
        Attention needed from Siddhartha S

        Wenyu Fu voted and added 1 comment

        Votes added by Wenyu Fu

        Code-Review+1

        1 comment

        File chrome/browser/actor/android/java/src/org/chromium/chrome/browser/actor/ui/ActorControlStateTracker.java
        Line 271, Patchset 5 (Latest): if (taskId <= 0) {
        Wenyu Fu . resolved

        Not a big fan of assuming taskId is a positive integer...

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Siddhartha S
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I775734e0b1536311d93cd001ba37aef7475fb851
        Gerrit-Change-Number: 7960601
        Gerrit-PatchSet: 5
        Gerrit-Owner: Siddhartha S <ss...@chromium.org>
        Gerrit-Reviewer: Hailey Wang <haile...@google.com>
        Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
        Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
        Gerrit-Attention: Siddhartha S <ss...@chromium.org>
        Gerrit-Comment-Date: Thu, 18 Jun 2026 04:55:32 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jun 18, 2026, 12:58:12 AM (6 days ago) Jun 18
        to Siddhartha S, Wenyu Fu, Hailey Wang, chromium...@chromium.org, aashna...@google.com, dewitt...@chromium.org, mfoltz+wa...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [Peek View] Adds support for multi-task tracking in Peek View

        Reviewed in:
        https://chromium-review.googlesource.com/c/chromium/src/+/7953299
        - Adds infrastructure to get Actor task IDs from Glic instances
        - Peek View will now always display an active task if it is associated with the current conversation
        Bug: 523302608
        Change-Id: I775734e0b1536311d93cd001ba37aef7475fb851
        Reviewed-by: Hailey Wang <haile...@google.com>
        Commit-Queue: Siddhartha S <ss...@chromium.org>
        Reviewed-by: Wenyu Fu <wen...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1648798}
        Files:
        • M chrome/browser/actor/android/java/src/org/chromium/chrome/browser/actor/ui/ActorControlCoordinator.java
        • M chrome/browser/actor/android/java/src/org/chromium/chrome/browser/actor/ui/ActorControlCoordinatorTest.java
        • M chrome/browser/actor/android/java/src/org/chromium/chrome/browser/actor/ui/ActorControlStateTracker.java
        • M chrome/browser/glic/actor/glic_actor_task_manager.cc
        • M chrome/browser/glic/actor/glic_actor_task_manager.h
        • M chrome/browser/glic/android/java/src/org/chromium/chrome/browser/glic/GlicInstanceHelper.java
        • M chrome/browser/glic/glic_tab_restore_helper_browsertest.cc
        • M chrome/browser/glic/service/glic_instance_helper.cc
        • M chrome/browser/glic/service/glic_instance_helper.h
        • M chrome/browser/glic/service/glic_instance_helper_android.cc
        • M chrome/browser/glic/service/glic_instance_helper_unittest.cc
        • M chrome/browser/glic/service/glic_instance_impl.cc
        • M chrome/browser/glic/service/glic_instance_impl.h
        Change size: L
        Delta: 13 files changed, 218 insertions(+), 90 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Wenyu Fu, +1 by Hailey Wang
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I775734e0b1536311d93cd001ba37aef7475fb851
        Gerrit-Change-Number: 7960601
        Gerrit-PatchSet: 6
        Gerrit-Owner: Siddhartha S <ss...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Hailey Wang <haile...@google.com>
        Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
        Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages