Rename immersive_mode_browser_view_test.cc to browsertest.cc [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Jun 18, 2026, 2:22:28 AM (2 days ago) Jun 18
to //chrome/browser/ui/views Reviews, chromium...@chromium.org
Attention needed from //chrome/browser/ui/views Reviews

Mitsuru Oshima voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • //chrome/browser/ui/views Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic15cb53bb32d702513874949c667f8af61b7df42
Gerrit-Change-Number: 7947921
Gerrit-PatchSet: 6
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 06:22:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jun 18, 2026, 2:24:03 AM (2 days ago) Jun 18
to Mitsuru Oshima, //chrome/browser/ui/views Reviews, Darryl James, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Darryl James

Message from gwsq

Reviewer source(s):
dlj...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic15cb53bb32d702513874949c667f8af61b7df42
Gerrit-Change-Number: 7947921
Gerrit-PatchSet: 6
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 06:23:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Darryl James (Gerrit)

unread,
Jun 18, 2026, 3:01:11 AM (2 days ago) Jun 18
to Mitsuru Oshima, //chrome/browser/ui/views Reviews, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Mitsuru Oshima

Darryl James voted and added 1 comment

Votes added by Darryl James

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Darryl James . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic15cb53bb32d702513874949c667f8af61b7df42
Gerrit-Change-Number: 7947921
Gerrit-PatchSet: 6
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 07:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Jun 18, 2026, 3:33:33 AM (2 days ago) Jun 18
to Darryl James, //chrome/browser/ui/views Reviews, Chromium LUCI CQ, chromium...@chromium.org

Mitsuru Oshima voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic15cb53bb32d702513874949c667f8af61b7df42
Gerrit-Change-Number: 7947921
Gerrit-PatchSet: 6
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: gwsq
Gerrit-Comment-Date: Thu, 18 Jun 2026 07:33:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 18, 2026, 3:52:24 AM (2 days ago) Jun 18
to Mitsuru Oshima, Darryl James, //chrome/browser/ui/views Reviews, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Rename immersive_mode_browser_view_test.cc to browsertest.cc

Bug: None
Change-Id: Ic15cb53bb32d702513874949c667f8af61b7df42
Bypass-Check-License: move file
Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
Reviewed-by: Darryl James <dlj...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648841}
Files:
  • R chrome/browser/ui/views/frame/immersive_mode_browser_view_browsertest.cc
  • M chrome/test/BUILD.gn
Change size: XS
Delta: 2 files changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darryl James
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic15cb53bb32d702513874949c667f8af61b7df42
Gerrit-Change-Number: 7947921
Gerrit-PatchSet: 7
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: gwsq
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages