Spanify `RedactionTool` (2/2) [chromium/src : main]

[Kalvin Lee (Gerrit)]

Attention needed from Xiangdong Kong

Kalvin Lee added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Kalvin Lee . resolved

Xiangdong for a third time for continuity...

Open in Gerrit

Related details

Attention is currently required from:

• Xiangdong Kong

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia79513fee6503c41b91726f2391f2d18c0a5267d

Gerrit-Change-Number: 7544239

Gerrit-PatchSet: 2

Gerrit-Owner: Kalvin Lee <kd...@chromium.org>

Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>

Gerrit-Reviewer: Xiangdong Kong <xiangd...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xiangdong Kong <xiangd...@google.com>

Gerrit-Comment-Date: Thu, 05 Feb 2026 06:34:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Xiangdong Kong (Gerrit)]

Attention needed from Kalvin Lee

Xiangdong Kong voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Kalvin Lee

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia79513fee6503c41b91726f2391f2d18c0a5267d

Gerrit-Change-Number: 7544239

Gerrit-PatchSet: 2

Gerrit-Owner: Kalvin Lee <kd...@chromium.org>

Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>

Gerrit-Reviewer: Xiangdong Kong <xiangd...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kalvin Lee <kd...@chromium.org>

Gerrit-Comment-Date: Thu, 05 Feb 2026 17:22:40 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Jason Robert Rauch (Gerrit)]

Attention needed from Kalvin Lee

Jason Robert Rauch added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jason Robert Rauch . resolved

CONCIDERING I DONT EVEN KNOW WHAT PROGRAMS OR PROCESS YOU USE ITS MAKEING THIS VERRY DIFFICULT FOR ME TO FIGUTE OUT DO YOU HAVE ANY FORM OF INSTRUCTIONS YOU SEND OUT SO I CAN FINISH THESE WITHOUT GOING TO A PSYCH WARD?

Open in Gerrit

Related details

Attention is currently required from:

• Kalvin Lee

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia79513fee6503c41b91726f2391f2d18c0a5267d

Gerrit-Change-Number: 7544239

Gerrit-PatchSet: 2

Gerrit-Owner: Kalvin Lee <kd...@chromium.org>

Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>

Gerrit-Reviewer: Xiangdong Kong <xiangd...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Jason Robert Rauch <jjra...@gmail.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kalvin Lee <kd...@chromium.org>

Gerrit-Comment-Date: Sat, 07 Feb 2026 16:48:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jason Robert Rauch (Gerrit)]

Attention needed from Kalvin Lee

Jason Robert Rauch added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jason Robert Rauch . resolved

LOOKS LIKE ALL EDITS ARE DONE BUT IT SAYS THERE IS A MERGE CONFLICT I CANT SEE

Gerrit-Comment-Date: Sat, 07 Feb 2026 18:01:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jason Robert Rauch (Gerrit)]

Attention needed from Kalvin Lee

Jason Robert Rauch added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jason Robert Rauch . resolved

so i tried doing the notes for the code at the end but when I tried changing it in edit mode it said that the oatch took care of it parent 2 or something I think when i reached out becuse I didnt have the correct rights to edit anything in that section (endpoint API's:) I assune someone fixed it that way??? if i can get the rights and the patch removed id be more than happy to but as of now I can :-(

Gerrit-Comment-Date: Sat, 07 Feb 2026 18:27:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jason Robert Rauch (Gerrit)]

Attention needed from Kalvin Lee

Jason Robert Rauch added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jason Robert Rauch . resolved

does anyone know what the merge conflict is i dont have any rights to edit anything requested here i have been trying

Gerrit-Comment-Date: Sat, 07 Feb 2026 20:55:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jason Robert Rauch (Gerrit)]

Attention needed from Kalvin Lee

Jason Robert Rauch added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jason Robert Rauch . resolved

I have that file with the error want me to fix?

Gerrit-Comment-Date: Sun, 08 Feb 2026 02:19:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No