login: Pass ApplicationLocaleStorage to LoginDisplayHost* [chromium/src : main]

[Jun Ishiguro (Gerrit)]

Attention needed from Hidehiko Abe

Jun Ishiguro added 2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Jun Ishiguro . resolved

PTAL

File chrome/browser/ash/main_parts/chrome_browser_main_parts_ash.cc

Line 1345, Patchset 3 (Latest): g_browser_process->GetFeatures()->application_locale_storage(),

Jun Ishiguro . resolved

NOTE: BrowserProcessImpl::features_ is initialized on PreCreateThreads.

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia611fbcc58210b5785e57beee81c9aab1df5bae8

Gerrit-Change-Number: 7611191

Gerrit-PatchSet: 3

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Fri, 27 Feb 2026 03:59:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Hidehiko Abe (Gerrit)]

Attention needed from Jun Ishiguro

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review

+1

1 comment

File chrome/browser/ash/login/session/chrome_session_manager.h

Line 58, Patchset 3 (Latest): // `application_locale_storage` must noe be nullptr, and must be valid while

Hidehiko Abe . unresolved

nit: not

Open in Gerrit

Related details

Attention is currently required from:

• Jun Ishiguro

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia611fbcc58210b5785e57beee81c9aab1df5bae8

Gerrit-Change-Number: 7611191

Gerrit-PatchSet: 3

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jun Ishiguro <ju...@google.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 02:54:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Jun Ishiguro (Gerrit)]

Jun Ishiguro voted and added 2 comments

Votes added by Jun Ishiguro

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Jun Ishiguro . resolved

Thank you for the review!

File chrome/browser/ash/login/session/chrome_session_manager.h

Line 58, Patchset 3: // `application_locale_storage` must noe be nullptr, and must be valid while

Hidehiko Abe . resolved

nit: not

Jun Ishiguro

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia611fbcc58210b5785e57beee81c9aab1df5bae8

Gerrit-Change-Number: 7611191

Gerrit-PatchSet: 4

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Mon, 02 Mar 2026 04:37:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/ash/login/session/chrome_session_manager.h
Insertions: 1, Deletions: 1.

@@ -55,7 +55,7 @@
   //   - Launches the auto launched kiosk app;
   //   - Resumes user sessions on crash-and-restart;
   //   - Starts a stub login session for dev or test;
-  // `application_locale_storage` must noe be nullptr, and must be valid while
+  // `application_locale_storage` must not be nullptr, and must be valid while
   // main RunLoop is running. `shared_url_loader_factory` must not be nullptr.
   void Initialize(
       ApplicationLocaleStorage* application_locale_storage,
```

Change information

Commit message:

login: Pass ApplicationLocaleStorage to LoginDisplayHost*

This CL passes ApplicationLocaleStorage to LoginDisplayHostCommon, and
its subclasses (LoginDisplayHostMojo and LoginDisplayHostWebUI).

Bug: b:403154552

Change-Id: Ia611fbcc58210b5785e57beee81c9aab1df5bae8

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7611191

Reviewed-by: Hidehiko Abe <hide...@chromium.org>

Commit-Queue: Jun Ishiguro <ju...@google.com>

Cr-Commit-Position: refs/heads/main@{#1592244}

Files:

• M chrome/browser/ash/login/session/chrome_session_manager.cc
• M chrome/browser/ash/login/session/chrome_session_manager.h
• M chrome/browser/ash/main_parts/chrome_browser_main_parts_ash.cc
• M chrome/browser/ui/ash/login/BUILD.gn
• M chrome/browser/ui/ash/login/DEPS
• M chrome/browser/ui/ash/login/login_display_host_common.cc
• M chrome/browser/ui/ash/login/login_display_host_common.h
• M chrome/browser/ui/ash/login/login_display_host_mojo.cc
• M chrome/browser/ui/ash/login/login_display_host_mojo.h
• M chrome/browser/ui/ash/login/login_display_host_webui.cc
• M chrome/browser/ui/ash/login/login_display_host_webui.h
• M chrome/browser/ui/ash/login/user_adding_screen.cc

Change size: M

Delta: 12 files changed, 78 insertions(+), 39 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Hidehiko Abe

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia611fbcc58210b5785e57beee81c9aab1df5bae8

Gerrit-Change-Number: 7611191

Gerrit-PatchSet: 5

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: chromium...@chromium.org