[Unchecked] Fix warnings in chrome/android customtabs, tab, toolbar [chromium/src : main]

0 views
Skip to first unread message

Jingping Sun (Gerrit)

unread,
4:33 AM (7 hours ago) 4:33 AM
to Calder Kitagawa, Andrew Grieve, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Peter Beverloo, hanxi...@chromium.org, lizeb+watch...@chromium.org, peilinwa...@google.com
Attention needed from Andrew Grieve and Calder Kitagawa

Jingping Sun added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jingping Sun . resolved

Hi, chromium committers. This CL is the part of unchecked warning enable task. Please help review, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic88a22c4012fd2777450ed88520218073d57fdd2
Gerrit-Change-Number: 7761064
Gerrit-PatchSet: 1
Gerrit-Owner: Jingping Sun <ji...@microsoft.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Jingping Sun <ji...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Apr 2026 08:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Calder Kitagawa (Gerrit)

unread,
8:11 AM (4 hours ago) 8:11 AM
to Jingping Sun, Andrew Grieve, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Peter Beverloo, hanxi...@chromium.org, lizeb+watch...@chromium.org, peilinwa...@google.com
Attention needed from Andrew Grieve and Jingping Sun

Calder Kitagawa voted and added 1 comment

Votes added by Calder Kitagawa

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Calder Kitagawa . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Jingping Sun
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic88a22c4012fd2777450ed88520218073d57fdd2
Gerrit-Change-Number: 7761064
Gerrit-PatchSet: 2
Gerrit-Owner: Jingping Sun <ji...@microsoft.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Jingping Sun <ji...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Jingping Sun <ji...@microsoft.com>
Gerrit-Comment-Date: Tue, 14 Apr 2026 12:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
9:26 AM (2 hours ago) 9:26 AM
to Jingping Sun, Calder Kitagawa, Andrew Grieve, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Peter Beverloo, hanxi...@chromium.org, lizeb+watch...@chromium.org, peilinwa...@google.com
Attention needed from Jingping Sun

Andrew Grieve added 1 comment

File chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/bottom/BottomControlsCoordinator.java
Line 62, Patchset 2 (Latest): private final OneshotSupplier<? extends BottomControlsContentDelegate> mContentDelegateSupplier;
Andrew Grieve . unresolved

Sorry to be annoying, but instead of using `? extends`, can you create another overload for [`SupplierUtils.upcast()`](https://source.chromium.org/chromium/chromium/src/+/main:base/android/java/src/org/chromium/base/supplier/SupplierUtils.java;drc=4674a5476b49b6ebde777ac100a49a095634152b;l=138) to fix this?

Open in Gerrit

Related details

Attention is currently required from:
  • Jingping Sun
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic88a22c4012fd2777450ed88520218073d57fdd2
    Gerrit-Change-Number: 7761064
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jingping Sun <ji...@microsoft.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Reviewer: Jingping Sun <ji...@microsoft.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Jingping Sun <ji...@microsoft.com>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 13:25:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jingping Sun (Gerrit)

    unread,
    11:25 AM (20 minutes ago) 11:25 AM
    to Calder Kitagawa, Andrew Grieve, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Peter Beverloo, pasko...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, agriev...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, peilinwa...@google.com
    Attention needed from Andrew Grieve and Calder Kitagawa

    Jingping Sun added 1 comment

    File chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/bottom/BottomControlsCoordinator.java
    Line 62, Patchset 2: private final OneshotSupplier<? extends BottomControlsContentDelegate> mContentDelegateSupplier;
    Andrew Grieve . resolved

    Sorry to be annoying, but instead of using `? extends`, can you create another overload for [`SupplierUtils.upcast()`](https://source.chromium.org/chromium/chromium/src/+/main:base/android/java/src/org/chromium/base/supplier/SupplierUtils.java;drc=4674a5476b49b6ebde777ac100a49a095634152b;l=138) to fix this?

    Jingping Sun

    Many thanks for the suggestion! Done. Please help take a look again.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Grieve
    • Calder Kitagawa
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic88a22c4012fd2777450ed88520218073d57fdd2
    Gerrit-Change-Number: 7761064
    Gerrit-PatchSet: 4
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 15:25:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Andrew Grieve <agr...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    11:35 AM (10 minutes ago) 11:35 AM
    to Jingping Sun, Andrew Grieve, Calder Kitagawa, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Peter Beverloo, pasko...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, agriev...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, peilinwa...@google.com
    Attention needed from Calder Kitagawa and Jingping Sun

    Andrew Grieve voted and added 1 comment

    Votes added by Andrew Grieve

    Code-Review+1
    Owners-Override+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Andrew Grieve . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Calder Kitagawa
    • Jingping Sun
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic88a22c4012fd2777450ed88520218073d57fdd2
    Gerrit-Change-Number: 7761064
    Gerrit-PatchSet: 4
    Gerrit-Owner: Jingping Sun <ji...@microsoft.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Reviewer: Jingping Sun <ji...@microsoft.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Jingping Sun <ji...@microsoft.com>
    Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 15:35:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Calder Kitagawa (Gerrit)

    unread,
    11:36 AM (9 minutes ago) 11:36 AM
    to Jingping Sun, Andrew Grieve, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Peter Beverloo, pasko...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, agriev...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, peilinwa...@google.com
    Attention needed from Jingping Sun

    Calder Kitagawa voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jingping Sun
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic88a22c4012fd2777450ed88520218073d57fdd2
    Gerrit-Change-Number: 7761064
    Gerrit-PatchSet: 4
    Gerrit-Owner: Jingping Sun <ji...@microsoft.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Reviewer: Jingping Sun <ji...@microsoft.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Jingping Sun <ji...@microsoft.com>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 15:36:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages