[Web UI] Remove NTP theme on Android desktop. [chromium/src : main]

0 views

Skip to first unread message

Xi Han (Gerrit)

unread,

Jul 7, 2026, 3:26:36 PM (yesterday) Jul 7

to Yanling Hu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Yanling Hu

Xi Han added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Xi Han . resolved

Can we add some tests? Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Yanling Hu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xi Han (Gerrit)

unread,

4:09 PM (3 hours ago) 4:09 PM

to Yanling Hu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Yanling Hu

Xi Han voted and added 2 comments

Votes added by Xi Han

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Xi Han . resolved

Lgtm with nit.

File chrome/browser/ntp_customization/junit/src/org/chromium/chrome/browser/ntp_customization/theme/NtpCustomizationPromoManagerUnitTest.java

Line 402, Patchset 6:

        when(mTab.isIncognitoBranded()).thenReturn(false);
        when(mTab.getUrl()).thenReturn(JUnitTestGURLs.NTP_URL);

Xi Han . unresolved

Can you move them to where it is used?