Attempt to fix flaky Windows tests. [chromium/src : main]
0 views
Skip to first unread message
Gustavo Martin (Gerrit)
2:43 PM (4 hours ago) 2:43 PM
to Lauren Winston, Chromium LUCI CQ, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Attention needed from Lauren Winston
Gustavo Martin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lauren Winston
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gustavo Martin (Gerrit)
2:43 PM (4 hours ago) 2:43 PM
to Lauren Winston, Chromium LUCI CQ, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Attention needed from Lauren Winston
Gustavo Martin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Gustavo Martin . resolved
LGTM but just curious on why these specific methods were added and not 'onScrolledToBottom' for example
Related details
Attention is currently required from:
- Lauren Winston
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lauren Winston (Gerrit)
3:24 PM (3 hours ago) 3:24 PM
to Gustavo Martin, Chromium LUCI CQ, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Lauren Winston voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:30 PM (3 hours ago) 3:30 PM
to Lauren Winston, Gustavo Martin, chromium...@chromium.org, jatapiaro+wat...@google.com, lwinston+watc...@google.com, trewin...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Attempt to fix flaky Windows tests.
The theory is that adding the missing methods to
fake_reading_mode.ts will help with timing / timeout issues
when the tests are run on certain tryjobs.
Fixed: 502069860
Change-Id: I14d920d9a5e13e27e4d737da0b02c8f6bd386dac
Commit-Queue: Lauren Winston <lwin...@google.com>
Reviewed-by: Gustavo Martin <gusm...@google.com>
Cr-Commit-Position: refs/heads/main@{#1659767}
Files:
- M chrome/test/data/webui/side_panel/read_anything/fake_reading_mode.ts
- M chrome/test/data/webui/side_panel/read_anything/read_anything_browsertest.cc
Change size: S
Delta: 2 files changed, 15 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gustavo Martin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages