Helmut Januschka (Gerrit)

unread,

Apr 3, 2026, 4:12:42 PM (10 days ago) Apr 3

to Helmut Januschka, David Bokan, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from David Bokan

Helmut Januschka added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Helmut Januschka . resolved

@bo...@chromium.org thanks in advanvce for your time.
please let me know if you want me to address anything.

Open in Gerrit

Related details

Attention is currently required from:

David Bokan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Bokan (Gerrit)

unread,

Apr 7, 2026, 5:10:55 PM (6 days ago) Apr 7

to Helmut Januschka, Kent Tamura, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Helmut Januschka and Kent Tamura

David Bokan added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

David Bokan . resolved

I'm going to punt to tkent@ who has more context around editing and text.

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka
Kent Tamura

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Apr 7, 2026, 7:10:52 PM (6 days ago) Apr 7

to Helmut Januschka, Koji Ishii, Kent Tamura, David Bokan, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Helmut Januschka and Koji Ishii

Kent Tamura added 3 comments

File third_party/blink/renderer/platform/text/text_break_iterator.cc

Line 304, Patchset 3 (Latest): // See https://issues.chromium.org/issues/40886057

Kent Tamura . unresolved

This issue doesn't contain any helpful information. Let's remove the line.

File third_party/blink/renderer/platform/text/text_break_iterator_test.cc

Line 344, Patchset 3 (Latest):// See https://issues.chromium.org/issues/40886057

Kent Tamura . unresolved

Ditto.

Line 362, Patchset 3 (Latest):

  if (test_string_.Is8Bit()) {
    test_string_ = String::Make16BitFrom8BitSource(test_string_.Span8());
  }

Kent Tamura . unresolved

I think this code is unnecessary.

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Helmut Januschka (Gerrit)

unread,

Apr 12, 2026, 3:22:09 PM (17 hours ago) Apr 12

to Helmut Januschka, Koji Ishii, Kent Tamura, David Bokan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Kent Tamura and Koji Ishii

Helmut Januschka added 3 comments

File third_party/blink/renderer/platform/text/text_break_iterator.cc

Line 304, Patchset 3: // See https://issues.chromium.org/issues/40886057

Kent Tamura . resolved

This issue doesn't contain any helpful information. Let's remove the line.

Helmut Januschka

Done

File third_party/blink/renderer/platform/text/text_break_iterator_test.cc

Line 344, Patchset 3:// See https://issues.chromium.org/issues/40886057

Kent Tamura . resolved

Ditto.

Helmut Januschka

Done

Line 362, Patchset 3:

  if (test_string_.Is8Bit()) {
    test_string_ = String::Make16BitFrom8BitSource(test_string_.Span8());
  }

Kent Tamura . resolved

I think this code is unnecessary.

Helmut Januschka

Done

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Apr 12, 2026, 6:13:20 PM (14 hours ago) Apr 12

to Helmut Januschka, Kent Tamura, Koji Ishii, David Bokan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Helmut Januschka and Koji Ishii

Kent Tamura voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

1:54 AM (6 hours ago) 1:54 AM

to Helmut Januschka, Kent Tamura, David Bokan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Helmut Januschka

Koji Ishii added 1 comment

File third_party/blink/renderer/platform/text/text_break_iterator.cc

Line 301, Patchset 4 (Latest): // LB21: Do not break before BA (Break After) class characters

Koji Ishii . unresolved

Can you move this block to inside of `ShouldBreakAfterBreakAll`, by passing `strictness_`?

Also, looking at [all characters of BA](https://util.unicode.org/UnicodeJsps/list-unicodeset.jsp?a=%5B%3Alb%3DBA%3A%5D&g=&i=), other browsers behaviors, and compatibility, can you exclude U+007F? Reading https://github.com/w3c/csswg-drafts/issues/4765 that resulted in this wpt test, U+007F isn't important for your case, right?

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Helmut Januschka (Gerrit)

unread,

6:00 AM (2 hours ago) 6:00 AM

to Helmut Januschka, Kent Tamura, Koji Ishii, David Bokan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Koji Ishii

Helmut Januschka added 1 comment

File third_party/blink/renderer/platform/text/text_break_iterator.cc

Line 301, Patchset 4: // LB21: Do not break before BA (Break After) class characters

Koji Ishii . resolved

Can you move this block to inside of `ShouldBreakAfterBreakAll`, by passing `strictness_`?
Also, looking at [all characters of BA](https://util.unicode.org/UnicodeJsps/list-unicodeset.jsp?a=%5B%3Alb%3DBA%3A%5D&g=&i=), other browsers behaviors, and compatibility, can you exclude U+007F? Reading https://github.com/w3c/csswg-drafts/issues/4765 that resulted in this wpt test, U+007F isn't important for your case, right?

Helmut Januschka

done. agreed it's not relevant to the use case.

Open in Gerrit

Related details

Attention is currently required from:

Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

6:09 AM (2 hours ago) 6:09 AM

to Helmut Januschka, Kent Tamura, David Bokan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Helmut Januschka

Koji Ishii added 1 comment

File third_party/blink/renderer/platform/text/text_break_iterator.cc

Line 142, Patchset 6 (Latest): if (line_break == U_LB_BREAK_AFTER && ch != 0x007F &&

Koji Ishii . unresolved

Oops, sorry for my typo, this should be `0x007C` instead, and the diff in `word-break-all-ascii-expected.txt` should be gone. `0x007F` isn't in the BA list...

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Helmut Januschka (Gerrit)

unread,

6:30 AM (2 hours ago) 6:30 AM

to Helmut Januschka, Kent Tamura, Koji Ishii, David Bokan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Kent Tamura and Koji Ishii

Helmut Januschka added 1 comment

File third_party/blink/renderer/platform/text/text_break_iterator.cc

Line 142, Patchset 6: if (line_break == U_LB_BREAK_AFTER && ch != 0x007F &&

Koji Ishii . resolved

Oops, sorry for my typo, this should be `0x007C` instead, and the diff in `word-break-all-ascii-expected.txt` should be gone. `0x007F` isn't in the BA list...

Helmut Januschka

Done, thanks

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

7:36 AM (1 hour ago) 7:36 AM

to Helmut Januschka, Kent Tamura, David Bokan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Helmut Januschka and Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Koji Ishii . resolved

lgtm, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka
Kent Tamura

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Fix word-break:break-all breaking before BA-class characters [chromium/src : main]

Helmut Januschka (Gerrit)

Helmut Januschka added 1 comment

Related details

David Bokan (Gerrit)

David Bokan added 1 comment

Related details

Kent Tamura (Gerrit)

Kent Tamura added 3 comments

Related details

Helmut Januschka (Gerrit)

Helmut Januschka added 3 comments

Related details

Kent Tamura (Gerrit)

Kent Tamura voted Code-Review+1

Related details

Koji Ishii (Gerrit)

Koji Ishii added 1 comment

Related details

Helmut Januschka (Gerrit)

Helmut Januschka added 1 comment

Related details

Koji Ishii (Gerrit)

Koji Ishii added 1 comment

Related details

Helmut Januschka (Gerrit)

Helmut Januschka added 1 comment

Related details

Koji Ishii (Gerrit)

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

1 comment

Related details