Clean up: Fix 41 wrong escapes in 25 DEPS files in ui [chromium/src : main]
0 views
Skip to first unread message
Yoshiki IGUCHI (Gerrit)
May 29, 2026, 5:30:27 PM (2 days ago) May 29
to Yoshiki IGUCHI, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, droger+w...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Mitsuru Oshima
Yoshiki IGUCHI added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
May 29, 2026, 5:45:54 PM (2 days ago) May 29
to Yoshiki IGUCHI, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, droger+w...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Yoshiki IGUCHI
Mitsuru Oshima voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yoshiki IGUCHI
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshiki IGUCHI (Gerrit)
May 29, 2026, 5:53:52 PM (2 days ago) May 29
to Yoshiki IGUCHI, Chromium UI Views Reviews, Chromium IPC Reviews, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, droger+w...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Chromium IPC Reviews and Chromium UI Views Reviews
Yoshiki IGUCHI added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yoshiki IGUCHI . resolved
chromium-ui-...@google.com, PTAL at ui/views changes
chrome-ip...@google.com, PTAL at ui/gfx/mojom change
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Chromium UI Views Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
May 29, 2026, 5:54:46 PM (2 days ago) May 29
to Yoshiki IGUCHI, Chromium UI Views Reviews, Chromium IPC Reviews, Allen Bauer, Hidehiko Abe, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, droger+w...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Allen Bauer and Hidehiko Abe
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: hide...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): hide...@chromium.org
Reviewer source(s):
hide...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
kyl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)
Related details
Attention is currently required from:
- Allen Bauer
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
May 31, 2026, 10:34:08 PM (2 hours ago) May 31
to Yoshiki IGUCHI, Chromium UI Views Reviews, Chromium IPC Reviews, Allen Bauer, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, droger+w...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Allen Bauer and Yoshiki IGUCHI
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
File ui/base/test/DEPS
Line 5, Patchset 2 (Latest):
"skia_gold_pixel_diff.cc": [Hidehiko Abe . unresolved
`\\.cc`?
Ditto for below.
Related details
Attention is currently required from:
- Allen Bauer
- Yoshiki IGUCHI
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages