Enable RGB10A2 overlay support for HDR video playing on Intel [chromium/src : main]

0 views
Skip to first unread message

Chunbo Hua (Gerrit)

unread,
Jul 8, 2025, 4:36:03 AMJul 8
to Maggie Chen, chromium...@chromium.org
Attention needed from Maggie Chen

Chunbo Hua voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Maggie Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
Gerrit-Change-Number: 6713776
Gerrit-PatchSet: 1
Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
Gerrit-Attention: Maggie Chen <mag...@chromium.org>
Gerrit-Comment-Date: Tue, 08 Jul 2025 08:35:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Maggie Chen (Gerrit)

unread,
Jul 8, 2025, 8:58:16 PMJul 8
to Chunbo Hua, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Chunbo Hua

Maggie Chen added 2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Maggie Chen . resolved

Thanks.

File gpu/config/gpu_driver_bug_list.json
Line 3623, Patchset 1 (Latest): "type": "win",
"version": {
"op": "<",
"value": "10.0.26100.4061"
}
},
Maggie Chen . unresolved

How about the very old Intel GPUs that are not capable of hardware overlay? Doesn't this force overlay support for those old GPUs as well?

Open in Gerrit

Related details

Attention is currently required from:
  • Chunbo Hua
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
    Gerrit-Change-Number: 6713776
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
    Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
    Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
    Gerrit-Attention: Chunbo Hua <chunb...@intel.com>
    Gerrit-Comment-Date: Wed, 09 Jul 2025 00:58:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Chunbo Hua (Gerrit)

    unread,
    Jul 9, 2025, 12:33:14 AMJul 9
    to Chromium LUCI CQ, Maggie Chen, chromium...@chromium.org
    Attention needed from Maggie Chen

    Chunbo Hua added 1 comment

    File gpu/config/gpu_driver_bug_list.json
    Line 3623, Patchset 1 (Latest): "type": "win",
    "version": {
    "op": "<",
    "value": "10.0.26100.4061"
    }
    },
    Maggie Chen . resolved

    How about the very old Intel GPUs that are not capable of hardware overlay? Doesn't this force overlay support for those old GPUs as well?

    Attention is currently required from:
    • Maggie Chen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
    Gerrit-Change-Number: 6713776
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
    Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
    Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
    Gerrit-Attention: Maggie Chen <mag...@chromium.org>
    Gerrit-Comment-Date: Wed, 09 Jul 2025 04:33:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Maggie Chen <mag...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maggie Chen (Gerrit)

    unread,
    Jul 10, 2025, 3:03:50 PMJul 10
    to Chunbo Hua, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Chunbo Hua

    Maggie Chen added 2 comments

    Maggie Chen . resolved

    Thanks.

    File gpu/config/gpu_driver_bug_list.json
    Line 3624, Patchset 2 (Latest): "version": {
    "op": "<",
    "value": "10.0.26100.4061"
    Maggie Chen . unresolved

    Is this the same as bug id 346 above, since 10.0.26100.4061 < 32.0.101.6314 already?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chunbo Hua
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
      Gerrit-Change-Number: 6713776
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
      Gerrit-Attention: Chunbo Hua <chunb...@intel.com>
      Gerrit-Comment-Date: Thu, 10 Jul 2025 19:03:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Chunbo Hua (Gerrit)

      unread,
      Jul 10, 2025, 9:14:29 PMJul 10
      to Chromium LUCI CQ, Maggie Chen, chromium...@chromium.org
      Attention needed from Maggie Chen

      Chunbo Hua added 1 comment

      File gpu/config/gpu_driver_bug_list.json
      Line 3624, Patchset 2 (Latest): "version": {
      "op": "<",
      "value": "10.0.26100.4061"
      Maggie Chen . unresolved

      Is this the same as bug id 346 above, since 10.0.26100.4061 < 32.0.101.6314 already?

      Chunbo Hua

      These are two different things (OS vs driver), which means it requires two fixings (one is in Windows OS 10.0.26100.4061, another one is in Intel driver 32.0.101.6314) to make RGB10A2 overlay check API work.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Maggie Chen
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
      Gerrit-Change-Number: 6713776
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
      Gerrit-Attention: Maggie Chen <mag...@chromium.org>
      Gerrit-Comment-Date: Fri, 11 Jul 2025 01:14:18 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Maggie Chen <mag...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Maggie Chen (Gerrit)

      unread,
      Jul 10, 2025, 9:16:15 PMJul 10
      to Chunbo Hua, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Chunbo Hua

      Maggie Chen voted and added 2 comments

      Votes added by Maggie Chen

      Code-Review+1

      2 comments

      Patchset-level comments
      Maggie Chen . resolved

      LGTM

      File gpu/config/gpu_driver_bug_list.json
      Line 3624, Patchset 2 (Latest): "version": {
      "op": "<",
      "value": "10.0.26100.4061"
      Maggie Chen . resolved

      Is this the same as bug id 346 above, since 10.0.26100.4061 < 32.0.101.6314 already?

      Chunbo Hua

      These are two different things (OS vs driver), which means it requires two fixings (one is in Windows OS 10.0.26100.4061, another one is in Intel driver 32.0.101.6314) to make RGB10A2 overlay check API work.

      Maggie Chen

      Thanks. I missed that one is the OS and the other is the driver.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chunbo Hua
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
      Gerrit-Change-Number: 6713776
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
      Gerrit-Attention: Chunbo Hua <chunb...@intel.com>
      Gerrit-Comment-Date: Fri, 11 Jul 2025 01:16:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Maggie Chen <mag...@chromium.org>
      Comment-In-Reply-To: Chunbo Hua <chunb...@intel.com>
      satisfied_requirement
      open
      diffy

      Chunbo Hua (Gerrit)

      unread,
      Jul 10, 2025, 9:24:13 PMJul 10
      to Chromium LUCI CQ, chromium...@chromium.org

      Chunbo Hua voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
      Gerrit-Change-Number: 6713776
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
      Gerrit-Comment-Date: Fri, 11 Jul 2025 01:24:03 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 10, 2025, 11:48:25 PMJul 10
      to Chunbo Hua, Maggie Chen, chromium...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Enable RGB10A2 overlay support for HDR video playing on Intel

      Two parts of the fixing have been done in Windows OS and Intel driver:
      1. RGB capability report (including RGB10A2) issue inside Intel driver
      2. Windows D3D API fails to deal with RGB pixel format

      Both of the above have been landed and rolled out into public accordingly.
      Bug: 1062184, 344343039
      Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
      Commit-Queue: Chunbo Hua <chunb...@intel.com>
      Reviewed-by: Maggie Chen <mag...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1485348}
      Files:
      • M gpu/config/gpu_driver_bug_list.json
      Change size: S
      Delta: 1 file changed, 35 insertions(+), 2 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Maggie Chen
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I234eda8a571bfc18298b652dccd1b797c74de53c
      Gerrit-Change-Number: 6713776
      Gerrit-PatchSet: 3
      Gerrit-Owner: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Chunbo Hua <chunb...@intel.com>
      Gerrit-Reviewer: Maggie Chen <mag...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages