Add render blocking status to Performance Resource Timing [chromium/src : main]

0 views
Skip to first unread message

Yoav Weiss (Gerrit)

unread,
Jun 28, 2022, 12:11:42 PMJun 28
to Abin Paul, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Tricium, chromium...@chromium.org, Nate Chapin

Attention is currently required from: Abin Paul.

View Change

4 comments:

To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
Gerrit-Change-Number: 3709521
Gerrit-PatchSet: 5
Gerrit-Owner: Abin Paul <abin....@gmail.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Yoav Weiss <yoav...@chromium.org>
Gerrit-Attention: Abin Paul <abin....@gmail.com>
Gerrit-Comment-Date: Tue, 28 Jun 2022 16:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Blink W3C Test Autoroller (Gerrit)

unread,
Jun 28, 2022, 12:18:14 PMJun 28
to Abin Paul, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Chromium LUCI CQ, Yoav Weiss, Tricium, chromium...@chromium.org, Nate Chapin

Attention is currently required from: Abin Paul.

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/34628.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

View Change

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 5
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Comment-Date: Tue, 28 Jun 2022 16:18:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Yoav Weiss (Gerrit)

    unread,
    Jun 28, 2022, 2:27:22 PMJun 28
    to Abin Paul, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul.

    View Change

    1 comment:

    • Patchset:

      • Patch Set #5:

        The test failures seem relevant. You probably need to update the webexposed expectations

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 5
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Comment-Date: Tue, 28 Jun 2022 18:27:09 +0000

    Abin Paul (Gerrit)

    unread,
    Jun 29, 2022, 3:51:25 AMJun 29
    to blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Blink W3C Test Autoroller, Chromium LUCI CQ, Yoav Weiss, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Yoav Weiss.

    View Change

    2 comments:

    • File third_party/blink/renderer/core/timing/performance_resource_timing.cc:

      • Add parenthesis? (they are not required, but I prefer them when they're not colliding with surroundi […]

        Added

    • File third_party/blink/renderer/platform/runtime_enabled_features.json5:

      • Changed

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 7
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Jun 2022 07:51:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Yoav Weiss <yoav...@chromium.org>
    Gerrit-MessageType: comment

    Abin Paul (Gerrit)

    unread,
    Jun 29, 2022, 9:12:29 AMJun 29
    to blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Yoav Weiss, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Hao Liu, Yoav Weiss.

    View Change

    1 comment:

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 8
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Jun 2022 13:12:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Yoav Weiss (Gerrit)

    unread,
    Jun 29, 2022, 1:33:25 PMJun 29
    to Abin Paul, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul, Hao Liu.

    View Change

    12 comments:

    • Patchset:

      • Patch Set #8:

        Thanks!! A few comments on the tests, mostly nits on their style

    • File third_party/blink/web_tests/external/wpt/resource-timing/render-blocking-status-link.html:

      • Patch Set #8, Line 8:

        Nit: spurious new line

      • Patch Set #8, Line 15: <link rel=stylesheet href='resources/empty_style.css?stylesheet-head'>

        In terms of style, it'd be nice to have consistency around single/double quotes for all the attributes

      • Patch Set #8, Line 21: <link rel=stylesheet id="link-head-remove-attr" blocking="render" href='resources/empty_style.css?stylesheet-head-blocking-render-remove-attr'>

        Can you break up long lines to try and get them to fit in 80 chars?

      • Patch Set #8, Line 27: <body>

        Can you explicitly close the <head> above this?

      • Patch Set #8, Line 119:

        Nit: spurious new line

      • Patch Set #8, Line 138: 'stylesheet-head-dynamic-innerHTML' : 'non-blocking',

        Can you put this in the same order as the resources? (so higher up)

        It's also not immediately obvious to me why this is "non blocking". Have you looked into it? Could it be a bug? If it isn't, a comment pointing to the spec indicating why this is correct would be useful

      • Patch Set #8, Line 141: 'stylesheet-head-dynamic-dom' : 'non-blocking',

        Same here, I'd naively expect this to be blocking..

    • File third_party/blink/web_tests/external/wpt/resource-timing/render-blocking-status-script.html:

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 8
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Jun 2022 17:33:14 +0000

    Abin Paul (Gerrit)

    unread,
    Jul 1, 2022, 11:47:01 AMJul 1
    to blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Yoav Weiss, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul, Hao Liu, Yoav Weiss.

    Patch set 9:Commit-Queue +1

    View Change

    11 comments:

    • File third_party/blink/web_tests/external/wpt/resource-timing/render-blocking-status-link.html:

      • Shall I keep it because now it separates the test case elements from the other elements?

      • In terms of style, it'd be nice to have consistency around single/double quotes for all the attribut […]

        Done

      • Patch Set #8, Line 21: <link rel=stylesheet id="link-head-remove-attr" blocking="render" href='resources/empty_style.css?stylesheet-head-blocking-render-remove-attr'>

        Can you break up long lines to try and get them to fit in 80 chars?

      • I've tried to break up lines that seemed long but the longer ones now still tend to lie in between 80-100 chars. Should I try again with a hard limit of 80 chars for the entire document?

      • Done

      • Removed

      • Can you put this in the same order as the resources? (so higher up) […]

        https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet
        says it is implicitly potentially render-blocking only if it was inserted by node document's parser, so I think its non-blocking when inserted by scripts. Am I understanding it right?
        I have tried to capture this in a comment before the start of the test cases that adds dynamic stylesheets.

      • Patch Set #8, Line 141: 'stylesheet-head-dynamic-dom' : 'non-blocking',

        Same here, I'd naively expect this to be blocking..

      • I believe this case will also be explained with the comment being added above.

    • File third_party/blink/web_tests/external/wpt/resource-timing/render-blocking-status-script.html:

      • Patch Set #8, Line 9: <script src="resources/empty_script.js?script-head"></script>

        Nit: You could add a comment above this line, indicating that this is the start of test cases..

      • Added.

      • Removed.

      • Done

      • Patch Set #8, Line 49: non_async_script.async = false;

        Worthwhile to point to the relevant spec indicating that this is correct

      • Done

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 9
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Attention: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Comment-Date: Fri, 01 Jul 2022 15:46:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    Abin Paul (Gerrit)

    unread,
    Jul 2, 2022, 7:53:57 AMJul 2
    to blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yoav Weiss, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Hao Liu, Yoav Weiss.

    View Change

    1 comment:

    • Patchset:

      • Patch Set #11:

        Build was failing because of a change that went in to the mainline. Fixed it now.

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 11
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Comment-Date: Sat, 02 Jul 2022 11:53:47 +0000

    Yoav Weiss (Gerrit)

    unread,
    Jul 3, 2022, 8:53:09 AMJul 3
    to Abin Paul, blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul, Hao Liu.

    Patch set 11:Code-Review +1

    View Change

    5 comments:

    • Patchset:

    • File third_party/blink/web_tests/external/wpt/resource-timing/render-blocking-status-link.html:

      • Shall I keep it because now it separates the test case elements from the other elements?

        Cool

      • Patch Set #8, Line 21: <link rel=stylesheet id="link-head-remove-attr" blocking="render" href='resources/empty_style.css?stylesheet-head-blocking-render-remove-attr'>

      • I've tried to break up lines that seemed long but the longer ones now still tend to lie in between 8 […]

        Looks better, thanks!

      • I believe this case will also be explained with the comment being added above.

        cool

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 11
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Comment-Date: Sun, 03 Jul 2022 12:52:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Abin Paul <abin....@gmail.com>

    Yoav Weiss (Gerrit)

    unread,
    Jul 5, 2022, 3:30:25 AMJul 5
    to Abin Paul, blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Mike West, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul, Hao Liu, Mike West.

    View Change

    1 comment:

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 11
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Attention: Mike West <mk...@chromium.org>
    Gerrit-Comment-Date: Tue, 05 Jul 2022 07:30:16 +0000

    Mike West (Gerrit)

    unread,
    Jul 5, 2022, 4:09:04 AMJul 5
    to Abin Paul, blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yoav Weiss, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul, Hao Liu.

    Patch set 11:Code-Review +1

    View Change

    1 comment:

    • File third_party/blink/public/mojom/timing/resource_timing.mojom:

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 11
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Comment-Date: Tue, 05 Jul 2022 08:08:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Yoav Weiss (Gerrit)

    unread,
    Jul 5, 2022, 5:45:30 AMJul 5
    to Abin Paul, blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Mike West, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul, Hao Liu.

    Patch set 11:Commit-Queue +1

    View Change

    1 comment:

    • File third_party/blink/renderer/core/timing/performance_resource_timing.idl:

    To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
    Gerrit-Change-Number: 3709521
    Gerrit-PatchSet: 11
    Gerrit-Owner: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
    Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Abin Paul <abin....@gmail.com>
    Gerrit-Attention: Hao Liu <hao...@chromium.org>
    Gerrit-Comment-Date: Tue, 05 Jul 2022 09:45:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    Yoav Weiss (Gerrit)

    unread,
    Jul 5, 2022, 5:49:00 AMJul 5
    to Abin Paul, blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Mike West, Hao Liu, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Nate Chapin

    Attention is currently required from: Abin Paul, Hao Liu.

    Patch set 11:Commit-Queue +2

    View Change

      To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
      Gerrit-Change-Number: 3709521
      Gerrit-PatchSet: 11
      Gerrit-Owner: Abin Paul <abin....@gmail.com>
      Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
      Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
      Gerrit-Reviewer: Mike West <mk...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-Attention: Abin Paul <abin....@gmail.com>
      Gerrit-Attention: Hao Liu <hao...@chromium.org>
      Gerrit-Comment-Date: Tue, 05 Jul 2022 09:48:47 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 5, 2022, 7:13:52 AMJul 5
      to Abin Paul, blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yoav Weiss, Mike West, Hao Liu, Blink W3C Test Autoroller, Tricium, chromium...@chromium.org, Nate Chapin

      Chromium LUCI CQ submitted this change.

      View Change


      Approvals: Mike West: Looks good to me Yoav Weiss: Looks good to me; Commit
      Add render blocking status to Performance Resource Timing

      This CL introduces a renderBlockingStatus field to Performance Resource
      Timing object. This field is behind a Runtime Enabled Flag.

      Bug: 1337256
      Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3709521
      Commit-Queue: Yoav Weiss <yoav...@chromium.org>
      Reviewed-by: Yoav Weiss <yoav...@chromium.org>
      Reviewed-by: Mike West <mk...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1020810}
      ---
      M AUTHORS
      M third_party/blink/public/mojom/timing/resource_timing.mojom
      M third_party/blink/renderer/core/loader/cross_thread_resource_timing_info_copier.cc
      M third_party/blink/renderer/core/timing/performance.cc
      M third_party/blink/renderer/core/timing/performance_resource_timing.cc
      M third_party/blink/renderer/core/timing/performance_resource_timing.h
      M third_party/blink/renderer/core/timing/performance_resource_timing.idl
      M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
      M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
      M third_party/blink/renderer/platform/loader/fetch/resource_timing_info.h
      M third_party/blink/renderer/platform/runtime_enabled_features.json5
      A third_party/blink/web_tests/external/wpt/resource-timing/render-blocking-status-link.html
      A third_party/blink/web_tests/external/wpt/resource-timing/render-blocking-status-script.html
      A third_party/blink/web_tests/external/wpt/resource-timing/resources/empty_style.css
      M third_party/blink/web_tests/external/wpt/resource-timing/resources/fake_responses.py
      A third_party/blink/web_tests/external/wpt/resource-timing/resources/importer.css
      A third_party/blink/web_tests/external/wpt/resource-timing/resources/importer.js
      A third_party/blink/web_tests/external/wpt/resource-timing/resources/importer_async.js
      A third_party/blink/web_tests/external/wpt/resource-timing/resources/importer_dynamic.css
      A third_party/blink/web_tests/external/wpt/resource-timing/resources/importer_print.css
      M third_party/blink/web_tests/external/wpt/resource-timing/tojson.html
      M third_party/blink/web_tests/platform/generic/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
      M third_party/blink/web_tests/platform/generic/webexposed/global-interface-listing-dedicated-worker-expected.txt
      M third_party/blink/web_tests/platform/generic/webexposed/global-interface-listing-expected.txt
      M third_party/blink/web_tests/platform/generic/webexposed/global-interface-listing-shared-worker-expected.txt
      25 files changed, 507 insertions(+), 6 deletions(-)


      To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
      Gerrit-Change-Number: 3709521
      Gerrit-PatchSet: 12
      Gerrit-Owner: Abin Paul <abin....@gmail.com>
      Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
      Gerrit-Reviewer: Mike West <mk...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-MessageType: merged

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Jul 5, 2022, 8:09:28 AMJul 5
      to Abin Paul, Chromium LUCI CQ, blink-revie...@chromium.org, core-timi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yoav Weiss, Mike West, Hao Liu, Tricium, chromium...@chromium.org, Nate Chapin

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/34628

      View Change

        To view, visit change 3709521. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I0175fb0bce5e3e2aa8eeebd8cff3d2c9f920e3db
        Gerrit-Change-Number: 3709521
        Gerrit-PatchSet: 12
        Gerrit-Owner: Abin Paul <abin....@gmail.com>
        Gerrit-Reviewer: Abin Paul <abin....@gmail.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Hao Liu <hao...@chromium.org>
        Gerrit-Reviewer: Mike West <mk...@chromium.org>
        Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-CC: Nate Chapin <jap...@chromium.org>
        Gerrit-Comment-Date: Tue, 05 Jul 2022 12:09:18 +0000
        Reply all
        Reply to author
        Forward
        0 new messages