Fix cross-world Promise leak in navigator.keyboard.getLayoutMap() [chromium/src : main]

[Joe Downing (Gerrit)]

Attention needed from Colin Blundell

Joe Downing added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Joe Downing . resolved

The original author of this code is no longer working at Google or on Chromium so I am relying on the 'suggested reviewer' feature to find someone to help with it. Please feel free to suggest another reviewer if needed.

Thanks!
Joe

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia19bc3408e61ec160764f6229b6158fa5a912c3f

Gerrit-Change-Number: 7751051

Gerrit-PatchSet: 12

Gerrit-Owner: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Joe Downing <joe...@chromium.org>

Gerrit-CC: Elliott Sprehn <esp...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 18:53:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Colin Blundell (Gerrit)]

Attention needed from Joe Downing and Kentaro Hara

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Colin Blundell . resolved

Thanks! -> Kentaro to review or reroute

Open in Gerrit

Related details

Attention is currently required from:

• Joe Downing
• Kentaro Hara

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia19bc3408e61ec160764f6229b6158fa5a912c3f

Gerrit-Change-Number: 7751051

Gerrit-PatchSet: 12

Gerrit-Owner: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Elliott Sprehn <esp...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joe Downing <joe...@chromium.org>

Gerrit-Attention: Kentaro Hara <har...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 07:24:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kentaro Hara (Gerrit)]

Attention needed from Joe Downing and Yuki Shiino

Kentaro Hara added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Kentaro Hara . resolved

Yukishiino: Would you take a look? Is this a common way to cache script promise resolvers?

Open in Gerrit

Related details

Attention is currently required from:

• Joe Downing
• Yuki Shiino

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia19bc3408e61ec160764f6229b6158fa5a912c3f

Gerrit-Change-Number: 7751051

Gerrit-PatchSet: 12

Gerrit-Owner: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>

Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>

Gerrit-CC: Elliott Sprehn <esp...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joe Downing <joe...@chromium.org>

Gerrit-Attention: Yuki Shiino <yukis...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 07:29:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yuki Shiino (Gerrit)]

Attention needed from Joe Downing and Kentaro Hara

Yuki Shiino added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Kentaro Hara . resolved

Yukishiino: Would you take a look? Is this a common way to cache script promise resolvers?

Yuki Shiino

The implementation looks very reasonable to me, but probably you'd like to use [ScriptPromiseProperty](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/bindings/core/v8/script_promise_property.h) for this purpose. There have already been some use cases in Blink codebase, which you can reference about how to use it.

Open in Gerrit

Related details

Attention is currently required from:

• Joe Downing
• Kentaro Hara

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia19bc3408e61ec160764f6229b6158fa5a912c3f

Gerrit-Change-Number: 7751051

Gerrit-PatchSet: 12

Gerrit-Owner: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>

Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>

Gerrit-CC: Elliott Sprehn <esp...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joe Downing <joe...@chromium.org>

Gerrit-Attention: Kentaro Hara <har...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 08:32:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kentaro Hara <har...@chromium.org>