Fix SigninButtonRenderTest flakiness by avoiding activity recreation [chromium/src : main]

0 views

Skip to first unread message

gwsq (Gerrit)

unread,

12:21 AM (4 hours ago) 12:21 AM

to Jenna Himawan, Chrome Signin Android Reviews, Tanmoy Mollik, Peilin Wang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Peilin Wang and Tanmoy Mollik

Message from gwsq

Reviewer source(s):
triplo...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/signin/android/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Peilin Wang
Tanmoy Mollik

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tanmoy Mollik (Gerrit)

unread,

2:58 AM (1 hour ago) 2:58 AM

to Jenna Himawan, Chrome Signin Android Reviews, Peilin Wang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, hanxi...@chromium.org, peilinwa...@google.com

Attention needed from Jenna Himawan and Peilin Wang

Tanmoy Mollik added 1 comment

File chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/signin_button/SigninButtonRenderTest.java

Line 102, Patchset 4 (Latest):

            ThreadUtils.runOnUiThreadBlocking(
                    () -> {
                        SigninButtonCoordinator coordinator =
                                mActivityTestRule
                                        .getActivity()
                                        .getToolbarManager()
                                        .getTopToolbarCoordinator()
                                        .getSigninButtonCoordinatorForTesting();
                        if (coordinator != null) {
                            coordinator.setSyncServiceForTesting(null);
                        }
                    });

Tanmoy Mollik . unresolved

I wonder if this is strictly necessary. The test is not batched so the activity should be recreated. I don't think the test suite will be bached because it depends on native.