Move ForTesting() methods in AccessibilityState to test-only class 5/5 [chromium/src : main]

0 views
Skip to first unread message

Peter Kotwicz (Gerrit)

unread,
Aug 5, 2026, 7:18:37 PM (4 days ago) Aug 5
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org

Peter Kotwicz voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6613c8661e0f7e0897632863f6cc33b40160d5a9
Gerrit-Change-Number: 8183867
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 23:18:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Aug 6, 2026, 3:31:39 PM (3 days ago) Aug 6
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org
Gerrit-Comment-Date: Thu, 06 Aug 2026 19:31:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Aug 6, 2026, 3:57:58 PM (3 days ago) Aug 6
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org

Peter Kotwicz voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6613c8661e0f7e0897632863f6cc33b40160d5a9
Gerrit-Change-Number: 8183867
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Comment-Date: Thu, 06 Aug 2026 19:57:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Aug 6, 2026, 6:15:02 PM (3 days ago) Aug 6
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org

Peter Kotwicz voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6613c8661e0f7e0897632863f6cc33b40160d5a9
Gerrit-Change-Number: 8183867
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Comment-Date: Thu, 06 Aug 2026 22:14:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Aug 7, 2026, 1:33:04 PM (2 days ago) Aug 7
to Andrew Grieve, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org
Attention needed from Andrew Grieve

Peter Kotwicz added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Peter Kotwicz . resolved

agrieve@ can you please take a look?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6613c8661e0f7e0897632863f6cc33b40160d5a9
Gerrit-Change-Number: 8183867
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Fri, 07 Aug 2026 17:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Aug 7, 2026, 2:39:17 PM (2 days ago) Aug 7
to Peter Kotwicz, Andrew Grieve, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org
Attention needed from Peter Kotwicz

Andrew Grieve voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Peter Kotwicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6613c8661e0f7e0897632863f6cc33b40160d5a9
Gerrit-Change-Number: 8183867
Gerrit-PatchSet: 10
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Comment-Date: Fri, 07 Aug 2026 18:39:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Aug 7, 2026, 3:51:09 PM (2 days ago) Aug 7
to Andrew Grieve, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org

Peter Kotwicz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6613c8661e0f7e0897632863f6cc33b40160d5a9
Gerrit-Change-Number: 8183867
Gerrit-PatchSet: 11
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Comment-Date: Fri, 07 Aug 2026 19:50:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Aug 8, 2026, 9:30:50 PM (23 hours ago) Aug 8
to Andrew Grieve, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org

Peter Kotwicz voted Commit-Queue+1

Commit-Queue+1
Gerrit-Comment-Date: Sun, 09 Aug 2026 01:30:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
5:20 PM (3 hours ago) 5:20 PM
to Andrew Grieve, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Mark Schillaci, android-web...@chromium.org, mschillaci...@google.com, abigailbk...@google.com, browser-comp...@chromium.org, davidj...@chromium.org, dtseng...@chromium.org, ender...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gogeral...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mattsimm...@chromium.org, meilian...@chromium.org, nektar...@chromium.org, wychen...@chromium.org, yongshun+...@google.com, yuezhang...@chromium.org, yusufo...@chromium.org, yuzo+...@chromium.org

Peter Kotwicz voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Sun, 09 Aug 2026 21:20:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages