[permissions] Use WebContents over Browser as class and function param [chromium/src : main]

[Thomas Lukaszewicz (Gerrit)]

Attention needed from Thomas Nguyen

Thomas Lukaszewicz added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Thomas Lukaszewicz . resolved

Thomas ptal (sorry for the large diff, the change is mostly mechanical and related)

Open in Gerrit

Related details

Attention is currently required from:

• Thomas Nguyen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I949cccc246bd31db5d9d33c1a1396a0cf0e4188a

Gerrit-Change-Number: 7954119

Gerrit-PatchSet: 8

Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Thu, 18 Jun 2026 06:31:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Thomas Nguyen (Gerrit)]

Attention needed from Thomas Lukaszewicz

Thomas Nguyen voted and added 1 comment

Votes added by Thomas Nguyen

Code-Review

+1

1 comment

File chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view.cc

Line 286, Patchset 8 (Latest): Profile::FromBrowserContext(web_contents()->GetBrowserContext()), this,

Thomas Nguyen . unresolved

Is that intentional that we use this instead of `GetBrowser()`?

Open in Gerrit

Related details

Attention is currently required from:

• Thomas Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I949cccc246bd31db5d9d33c1a1396a0cf0e4188a

Gerrit-Change-Number: 7954119

Gerrit-PatchSet: 8

Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Thu, 18 Jun 2026 08:01:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Thomas Lukaszewicz (Gerrit)]

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Commit-Queue

+2

1 comment

File chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view.cc

Line 286, Patchset 8 (Latest): Profile::FromBrowserContext(web_contents()->GetBrowserContext()), this,

Thomas Nguyen . resolved

Is that intentional that we use this instead of `GetBrowser()`?

Thomas Lukaszewicz

Yeah it's intentional in this case - I shifted `PermissionPromptPreviewsCoordinator` over to using `Profile` since it only needed the `Profile`, only needed it in the constructor, and is a much smaller dependency than `Browser` (which we try to avoid if we can).

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I949cccc246bd31db5d9d33c1a1396a0cf0e4188a

Gerrit-Change-Number: 7954119

Gerrit-PatchSet: 8

Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 18 Jun 2026 16:36:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Thomas Nguyen <tun...@chromium.org>

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

[permissions] Use WebContents over Browser as class and function param

There are no intended behavioral changes.

This CL does the following to take WebContents constructor param
instead of Browser
- PermissionPromptBaseView and associated subclasses
- PermissionPromptDelegate
- GetUrlIdentity

The Browser is instead fetched on demand from the WebContents as
necessary.

Bug: 522965795

Change-Id: I949cccc246bd31db5d9d33c1a1396a0cf0e4188a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7954119

Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>

Reviewed-by: Thomas Nguyen <tun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1649116}

Files:

• M chrome/browser/ui/views/media_preview/permission_prompt_previews_coordinator.cc
• M chrome/browser/ui/views/media_preview/permission_prompt_previews_coordinator.h
• M chrome/browser/ui/views/media_preview/permission_prompt_previews_coordinator_unittest.cc
• M chrome/browser/ui/views/permissions/chip/chip_controller.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_ask_view.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_ask_view.h
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_base_view.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_base_view.h
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_policy_view.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_policy_view.h
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_previously_denied_view.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_previously_denied_view.h
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_previously_granted_view.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_previously_granted_view.h
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_show_system_prompt_view.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_show_system_prompt_view.h
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_system_settings_view.cc
• M chrome/browser/ui/views/permissions/embedded_permission_prompt_system_settings_view.h
• M chrome/browser/ui/views/permissions/exclusive_access_permission_prompt.cc
• M chrome/browser/ui/views/permissions/exclusive_access_permission_prompt_browsertest.cc
• M chrome/browser/ui/views/permissions/exclusive_access_permission_prompt_view.cc
• M chrome/browser/ui/views/permissions/exclusive_access_permission_prompt_view.h
• M chrome/browser/ui/views/permissions/permission_prompt_base_view.cc
• M chrome/browser/ui/views/permissions/permission_prompt_base_view.h
• M chrome/browser/ui/views/permissions/permission_prompt_base_view_browsertest.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_base_view.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_base_view.h
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view.h
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view_unittest.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_two_origins_view.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_two_origins_view.h
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_two_origins_view_browsertest.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_view_factory.cc
• M chrome/browser/ui/views/permissions/permission_prompt_bubble_view_factory.h

Change size: L

Delta: 37 files changed, 209 insertions(+), 139 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Thomas Nguyen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I949cccc246bd31db5d9d33c1a1396a0cf0e4188a

Gerrit-Change-Number: 7954119

Gerrit-PatchSet: 9

Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org