Fix the paste lag issue in views::Textfield. [chromium/src : main]

0 views
Skip to first unread message

Eshwar Stalin (Gerrit)

unread,
Dec 3, 2025, 12:37:26 PM (3 days ago) Dec 3
to Zifeng Shang, Mitsuru Oshima, hewro, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Mitsuru Oshima and Zifeng Shang

Eshwar Stalin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
  • Zifeng Shang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icbc59872b9dd9eb4f56ca487d1d1dab8af6b3493
Gerrit-Change-Number: 7220635
Gerrit-PatchSet: 4
Gerrit-Owner: Zifeng Shang <shang...@gmail.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: hewro <ihe...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Zifeng Shang <shang...@gmail.com>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Dec 2025 17:37:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zifeng Shang (Gerrit)

unread,
Dec 4, 2025, 9:23:09 PM (2 days ago) Dec 4
to Chromium UI Views Reviews, Eshwar Stalin, hewro, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Chromium UI Views Reviews

Zifeng Shang added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Zifeng Shang . resolved

I think users should be given an opportunity to decide on the pasted content, letting them determine the length and format of the content being pasted. Could you please help review the code when you have time?

Open in Gerrit

Related details

Attention is currently required from:
  • Chromium UI Views Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icbc59872b9dd9eb4f56ca487d1d1dab8af6b3493
Gerrit-Change-Number: 7220635
Gerrit-PatchSet: 4
Gerrit-Owner: Zifeng Shang <shang...@gmail.com>
Gerrit-Reviewer: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: hewro <ihe...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 02:22:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Dec 4, 2025, 9:25:03 PM (2 days ago) Dec 4
to Zifeng Shang, Chromium UI Views Reviews, Keren Zhu, Eshwar Stalin, hewro, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Keren Zhu

Message from gwsq

Reviewer source(s):
kere...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Keren Zhu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icbc59872b9dd9eb4f56ca487d1d1dab8af6b3493
Gerrit-Change-Number: 7220635
Gerrit-PatchSet: 4
Gerrit-Owner: Zifeng Shang <shang...@gmail.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
Gerrit-Reviewer: hewro <ihe...@chromium.org>
Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Keren Zhu <kere...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 02:24:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Dec 5, 2025, 5:44:05 PM (9 hours ago) Dec 5
to Zifeng Shang, Chromium UI Views Reviews, Keren Zhu, Eshwar Stalin, hewro, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Keren Zhu and Zifeng Shang

Mitsuru Oshima added 2 comments

Patchset-level comments
Mitsuru Oshima . resolved

wont this be an issue on other Textfields (e.g. omnibox) as well?

File chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
Line 68, Patchset 4 (Latest):// Pasting very large text (e.g., >10 MB) into views::Textfield causes severe UI
Mitsuru Oshima . unresolved

Is it pasting or rendering the large text causing the lag?

Open in Gerrit

Related details

Attention is currently required from:
  • Keren Zhu
  • Zifeng Shang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icbc59872b9dd9eb4f56ca487d1d1dab8af6b3493
    Gerrit-Change-Number: 7220635
    Gerrit-PatchSet: 4
    Gerrit-Owner: Zifeng Shang <shang...@gmail.com>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
    Gerrit-Reviewer: hewro <ihe...@chromium.org>
    Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Keren Zhu <kere...@chromium.org>
    Gerrit-Attention: Zifeng Shang <shang...@gmail.com>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 22:43:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keren Zhu (Gerrit)

    unread,
    Dec 5, 2025, 11:47:54 PM (3 hours ago) Dec 5
    to Zifeng Shang, Mitsuru Oshima, Chromium UI Views Reviews, Eshwar Stalin, hewro, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Zifeng Shang

    Keren Zhu added 4 comments

    Commit Message
    Line 12, Patchset 4 (Latest):and supply them to the Textfield.The Chrome address bar (Omnibox)
    Keren Zhu . unresolved

    ```suggestion
    and supply them to the Textfield. The Chrome address bar (Omnibox)
    ```

    Line 18, Patchset 4 (Latest):Bug: 457203690
    Keren Zhu . unresolved

    This bug is about pasting text to `chrome://bookmarks/` WebUI, not views.

    File chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
    Line 71, Patchset 4 (Latest):// Textfield.The Chrome address bar (Omnibox) mitigates this by truncating
    Keren Zhu . unresolved

    ```suggestion
    // Textfield. The Chrome address bar (Omnibox) mitigates this by truncating
    ```

    File ui/views/controls/textfield/textfield_unittest.cc
    Line 139, Patchset 4 (Latest): bool intercept)
    Keren Zhu . unresolved

    Can we make this controller always intercept the paste? If a test needs to test the non-intercepting case, it should not use this controller at all.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Zifeng Shang
    Gerrit-Attention: Zifeng Shang <shang...@gmail.com>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 04:47:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages