Remove Desktop Click to Call UI and context menus [chromium/src : main]

[Michael Tatarski (Gerrit)]

Attention needed from Ankush Singh

Michael Tatarski added 1 comment

File chrome/browser/ui/views/sharing/sharing_dialog_view_unittest.cc

Line 110, Patchset 3 (Latest): data.prefix = SharingFeatureName::kSmsRemoteFetcher;

Michael Tatarski . unresolved

This is a generic test file with a few tests that were specific to `ClickToCall`. To ensure the remaining tests keep passing, I had to change this dummy capability.

Open in Gerrit

Related details

Attention is currently required from:

• Ankush Singh

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibc6ef4af9f1ee04a01cc00a40b65fe78e3771c86

Gerrit-Change-Number: 8044703

Gerrit-PatchSet: 3

Gerrit-Owner: Michael Tatarski <mtat...@google.com>

Gerrit-Reviewer: Ankush Singh <ankus...@google.com>

Gerrit-Reviewer: Michael Tatarski <mtat...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ankush Singh <ankus...@google.com>

Gerrit-Comment-Date: Mon, 06 Jul 2026 10:38:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Greg Thompson (Gerrit)]

Attention needed from Ankush Singh and Michael Tatarski

Greg Thompson voted and added 2 comments

Votes added by Greg Thompson

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Greg Thompson . resolved

lgtm % a comment tweak. nice cleanup. deleting code is my favorite thing.

File chrome/browser/ui/views/intent_picker_bubble_view.cc

Line 669, Patchset 6 (Latest): // Click to call bubbles need to be closed after navigation if the main frame

Greg Thompson . unresolved

update comment

Open in Gerrit

Related details

Attention is currently required from:

• Ankush Singh
• Michael Tatarski

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibc6ef4af9f1ee04a01cc00a40b65fe78e3771c86

Gerrit-Change-Number: 8044703

Gerrit-PatchSet: 6

Gerrit-Owner: Michael Tatarski <mtat...@google.com>

Gerrit-Reviewer: Ankush Singh <ankus...@google.com>

Gerrit-Reviewer: Greg Thompson <g...@chromium.org>

Gerrit-Reviewer: Michael Tatarski <mtat...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ankush Singh <ankus...@google.com>

Gerrit-Attention: Michael Tatarski <mtat...@google.com>

Gerrit-Comment-Date: Mon, 06 Jul 2026 13:41:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ankush Singh (Gerrit)]

Attention needed from Michael Tatarski

Ankush Singh voted and added 1 comment

Votes added by Ankush Singh

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Ankush Singh . resolved

LGTM, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Michael Tatarski

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibc6ef4af9f1ee04a01cc00a40b65fe78e3771c86

Gerrit-Change-Number: 8044703

Gerrit-PatchSet: 7

Gerrit-Owner: Michael Tatarski <mtat...@google.com>

Gerrit-Reviewer: Ankush Singh <ankus...@google.com>

Gerrit-Reviewer: Greg Thompson <g...@chromium.org>

Gerrit-Reviewer: Michael Tatarski <mtat...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Michael Tatarski <mtat...@google.com>

Gerrit-Comment-Date: Tue, 07 Jul 2026 17:10:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Greg Thompson (Gerrit)]

Attention needed from Ankush Singh and Michael Tatarski

Greg Thompson voted and added 2 comments

Votes added by Greg Thompson

Code-Review

+1

2 comments

File chrome/browser/external_protocol/external_protocol_handler.cc

Line 42, Patchset 8 (Latest):

Greg Thompson . unresolved

remove extra blank line

Line 263, Patchset 8 (Latest):

Greg Thompson . unresolved

remove extra blank line

Open in Gerrit

Related details

Attention is currently required from:

• Ankush Singh
• Michael Tatarski

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibc6ef4af9f1ee04a01cc00a40b65fe78e3771c86

Gerrit-Change-Number: 8044703

Gerrit-PatchSet: 8

Gerrit-Owner: Michael Tatarski <mtat...@google.com>

Gerrit-Reviewer: Ankush Singh <ankus...@google.com>

Gerrit-Reviewer: Greg Thompson <g...@chromium.org>

Gerrit-Reviewer: Michael Tatarski <mtat...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ankush Singh <ankus...@google.com>

Gerrit-Attention: Michael Tatarski <mtat...@google.com>

Gerrit-Comment-Date: Wed, 08 Jul 2026 07:04:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes