[iOS][Composebox] Improve compact to expanded animation. [chromium/src : main]
0 views
Skip to first unread message
Stepan Khapugin (Gerrit)
Jul 8, 2026, 10:11:31 AM (2 days ago) Jul 8
to Radu Nitescu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Radu Nitescu
Stepan Khapugin voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Radu Nitescu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Radu Nitescu (Gerrit)
4:22 AM (3 hours ago) 4:22 AM
to Stepan Khapugin, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Stepan Khapugin
Radu Nitescu voted![]( "Open in Gerrit")
Attention is currently required from:
- Stepan Khapugin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:31 AM (2 hours ago) 5:31 AM
to Stepan Khapugin, Radu Nitescu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS][Composebox] Improve compact to expanded animation.
1. Move -updateInputPlateStackViewContent out of Layout, so that views
are created outside of the animation block
2. Preset the toolbar items horizontal positions by setting the frame to
its parent (this ensures correct width) and forcing a layout pass before
the animation block.
Bug: 525360729
Change-Id: I308eadaafc1d5968a0781688869561712f62d770
Reviewed-by: Radu Nitescu <radun...@google.com>
Commit-Queue: Radu Nitescu <radun...@google.com>
Auto-Submit: Stepan Khapugin <stkha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1660141}
Files:
- M ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm
Change size: XS
Delta: 1 file changed, 7 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Radu Nitescu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages