Introduce required constants from NtpNextFeatures in NTP 3P UI [chromium/src : main]

0 views
Skip to first unread message

Sho Mizoe (Gerrit)

unread,
3:45 PM (4 hours ago) 3:45 PM
to Tibor Goldschwendt, Riley Tatum, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Riley Tatum and Tibor Goldschwendt

Sho Mizoe voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Riley Tatum
  • Tibor Goldschwendt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I76013b14281f72ce225c2e633a9da69a6792d62f
Gerrit-Change-Number: 7064138
Gerrit-PatchSet: 6
Gerrit-Owner: Sho Mizoe <shom...@google.com>
Gerrit-Reviewer: Riley Tatum <rta...@google.com>
Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
Gerrit-Attention: Riley Tatum <rta...@google.com>
Gerrit-Attention: Tibor Goldschwendt <tib...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 19:45:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Riley Tatum (Gerrit)

unread,
4:11 PM (4 hours ago) 4:11 PM
to Sho Mizoe, Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Sho Mizoe and Tibor Goldschwendt

Riley Tatum voted and added 1 comment

Votes added by Riley Tatum

Code-Review+1

1 comment

Commit Message
Line 18, Patchset 6 (Latest):After the change, we have confirmed that NTP 3P loads successfully[3].
Riley Tatum . unresolved

Super Nit: go/avoidwe

Open in Gerrit

Related details

Attention is currently required from:
  • Sho Mizoe
  • Tibor Goldschwendt
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I76013b14281f72ce225c2e633a9da69a6792d62f
    Gerrit-Change-Number: 7064138
    Gerrit-PatchSet: 6
    Gerrit-Owner: Sho Mizoe <shom...@google.com>
    Gerrit-Reviewer: Riley Tatum <rta...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-Attention: Sho Mizoe <shom...@google.com>
    Gerrit-Attention: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Oct 2025 20:11:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sho Mizoe (Gerrit)

    unread,
    4:25 PM (4 hours ago) 4:25 PM
    to Riley Tatum, Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Tibor Goldschwendt

    Sho Mizoe voted and added 1 comment

    Votes added by Sho Mizoe

    Commit-Queue+1

    1 comment

    Commit Message
    Line 18, Patchset 6:After the change, we have confirmed that NTP 3P loads successfully[3].
    Riley Tatum . resolved

    Super Nit: go/avoidwe

    Sho Mizoe

    thanks, updated the CL description to avoid it

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tibor Goldschwendt
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I76013b14281f72ce225c2e633a9da69a6792d62f
      Gerrit-Change-Number: 7064138
      Gerrit-PatchSet: 7
      Gerrit-Owner: Sho Mizoe <shom...@google.com>
      Gerrit-Reviewer: Riley Tatum <rta...@google.com>
      Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
      Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
      Gerrit-Attention: Tibor Goldschwendt <tib...@chromium.org>
      Gerrit-Comment-Date: Mon, 20 Oct 2025 20:25:17 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Riley Tatum <rta...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Tibor Goldschwendt (Gerrit)

      unread,
      4:59 PM (3 hours ago) 4:59 PM
      to Sho Mizoe, Riley Tatum, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Sho Mizoe

      Tibor Goldschwendt added 1 comment

      Patchset-level comments
      File-level comment, Patchset 7 (Latest):
      Tibor Goldschwendt . unresolved

      Adding more 1P specific load time data to the 3P NTP is not the correct fix IMO. Rather, the parent should pass more generic configs to <cr-most-visited>. E.g. has show more, max number of tiles without show more, etc.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sho Mizoe
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I76013b14281f72ce225c2e633a9da69a6792d62f
        Gerrit-Change-Number: 7064138
        Gerrit-PatchSet: 7
        Gerrit-Owner: Sho Mizoe <shom...@google.com>
        Gerrit-Reviewer: Riley Tatum <rta...@google.com>
        Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
        Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
        Gerrit-Attention: Sho Mizoe <shom...@google.com>
        Gerrit-Comment-Date: Mon, 20 Oct 2025 20:59:21 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages