Harder viz: Add STACK_ALLOCATED to Embedder in overlay_processor_win.cc [chromium/src : main]

[Jonathan Ross (Gerrit)]

Attention needed from Kyle Charbonneau

Jonathan Ross added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jonathan Ross . resolved

Mind reviewing this? It seems to be performance neutral, but adds extra checks to prevent this struct from being accessed off the stack

Open in Gerrit

Related details

Attention is currently required from:

• Kyle Charbonneau

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d48bbabfab4ebff84984a7e5c643647de33f7d5

Gerrit-Change-Number: 7881446

Gerrit-PatchSet: 1

Gerrit-Owner: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kyle Charbonneau <kyle...@chromium.org>

Gerrit-Comment-Date: Thu, 28 May 2026 19:34:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No