cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols [infra/infra : main]
0 views
Skip to first unread message
Otabek Kasimov (Gerrit)
6:07 PM (3 hours ago) 6:07 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move shared container-based BOLS RPC handlers into ContainerService in
go.chromium.org/infra/cros/lib/bols/container_service.go.
Update bols_satlab to embed bols.ContainerService.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: Ibe4a676b5fc854ccbca415b84869e5691012cb89
Change diff
Change information
Files:
- M go/src/go.chromium.org/chromiumos/config
- M go/src/go.chromium.org/chromiumos/infra/proto
- M go/src/go.chromium.org/luci
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/common.go
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/docker_executor.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- A go/src/infra/cros/lib/bols/container_service.go
Change size: XL
Delta: 8 files changed, 1501 insertions(+), 1674 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
6:07 PM (3 hours ago) 6:07 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move shared container-based BOLS RPC handlers into ContainerService in
go.chromium.org/infra/cros/lib/bols/container_service.go.
Update bols_satlab to embed bols.ContainerService.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I06754b28614144aebd9ed08d273bab3916dc04c5
Change diff
diff --git a/go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go b/go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
index ff52e9d..5f69209 100644
--- a/go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
+++ b/go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
@@ -7,11 +7,13 @@
import (
"context"
"fmt"
+ "log"
"net"
"google.golang.org/grpc"
bols_service "go.chromium.org/chromiumos/config/go/test/api/bols"
+
"go.chromium.org/infra/cros/lib/bols"
)
@@ -41,6 +43,7 @@
go func() {
if err := srv.Serve(lis); err != nil && err != grpc.ErrServerStopped {
+ log.Printf("Serve error: %v", err)
}
}()
Change information
Files:
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
6:43 PM (2 hours ago) 6:43 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move shared container-based BOLS RPC handlers and domain services from
bols_satlab to go.chromium.org/infra/cros/lib/bols.
Update bols_satlab to embed bols.ContainerService.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I0d35dc0f3c4dd4685b4266773838f6a073a5579f
Change diff
Change information
Files:
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- M go/src/infra/cros/lib/bols/bols.go
- R go/src/infra/cros/lib/bols/cmd_service.go
- R go/src/infra/cros/lib/bols/common.go
- R go/src/infra/cros/lib/bols/docker_executor.go
- R go/src/infra/cros/lib/bols/file_service.go
- A go/src/infra/cros/lib/bols/service.go
- R go/src/infra/cros/lib/bols/servod_service.go
Change size: L
Delta: 9 files changed, 221 insertions(+), 234 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:04 PM (2 hours ago) 7:04 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move container-centric BOLS handlers (file_service, servod_lifecycle_service,
servod_control_service, dolos_service, cmd_service, docker_executor, common)
into lib/bols to enable reuse across BOLS runner implementations.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I21af1f905bf7256fdbae81e78aa517dc8c4efb91
Change diff
Change information
Files:
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- M go/src/infra/cros/lib/bols/bols.go
- R go/src/infra/cros/lib/bols/cmd_service.go
- R go/src/infra/cros/lib/bols/common.go
- R go/src/infra/cros/lib/bols/docker_executor.go
- A go/src/infra/cros/lib/bols/dolos_service.go
- R go/src/infra/cros/lib/bols/file_service.go
- A go/src/infra/cros/lib/bols/service.go
- R go/src/infra/cros/lib/bols/servod_control_service.go
- R go/src/infra/cros/lib/bols/servod_lifecycle_service.go
Change size: L
Delta: 12 files changed, 201 insertions(+), 207 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:11 PM (2 hours ago) 7:11 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move container-centric BOLS handlers (file_service, servod_lifecycle_service,
servod_control_service, dolos_service, cmd_service, ip_cache, local_dev, container_utils,
tar_utils, logger, util, docker_executor) into lib/bols to enable reuse across
BOLS runner implementations.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I35237df12656d27928067746ee22adf29dc4243e
Change diff
Change information
Files:
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/localserver.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- R go/src/infra/cros/lib/bols/cmd_service.go
- R go/src/infra/cros/lib/bols/container_utils.go
- R go/src/infra/cros/lib/bols/docker_executor.go
- A go/src/infra/cros/lib/bols/dolos_service.go
- R go/src/infra/cros/lib/bols/file_service.go
- R go/src/infra/cros/lib/bols/ip_cache.go
- R go/src/infra/cros/lib/bols/local_dev.go
- R go/src/infra/cros/lib/bols/logger.go
- A go/src/infra/cros/lib/bols/service.go
- R go/src/infra/cros/lib/bols/servod_control_service.go
- R go/src/infra/cros/lib/bols/servod_lifecycle_service.go
- R go/src/infra/cros/lib/bols/tar_utils.go
- R go/src/infra/cros/lib/bols/util.go
Change size: L
Delta: 16 files changed, 187 insertions(+), 202 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:23 PM (2 hours ago) 7:23 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move container-centric BOLS handlers (file_service, servod_lifecycle_service,
servod_control_service, dolos_service, cmd_service, ip_cache, local_dev, container_utils,
tar_utils, logger, util, docker_executor) into lib/bols to enable reuse across
BOLS runner implementations.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I29820c98f2834a53cdd9008adbb884508b2e9ec6
Change diff
Change information
Files:
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- R go/src/infra/cros/lib/bols/cmd_service.go
- R go/src/infra/cros/lib/bols/container_utils.go
- R go/src/infra/cros/lib/bols/docker_executor.go
- A go/src/infra/cros/lib/bols/dolos_service.go
- R go/src/infra/cros/lib/bols/file_service.go
- R go/src/infra/cros/lib/bols/ip_cache.go
- R go/src/infra/cros/lib/bols/local_dev.go
- R go/src/infra/cros/lib/bols/logger.go
- A go/src/infra/cros/lib/bols/service.go
- R go/src/infra/cros/lib/bols/servod_control_service.go
- R go/src/infra/cros/lib/bols/servod_lifecycle_service.go
- R go/src/infra/cros/lib/bols/tar_utils.go
- R go/src/infra/cros/lib/bols/util.go
Change size: L
Delta: 15 files changed, 175 insertions(+), 156 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:46 PM (1 hour ago) 7:46 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move container-centric BOLS handlers (file_service, servod_lifecycle_service,
servod_control_service, dolos_service, cmd_service, ip_cache, local_dev, container_utils,
tar_utils, logger, util, docker_executor) into lib/bols to enable reuse across
BOLS runner implementations.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I12224fb76a2eda1fa17a890abe5df348ebb29cbc
Change diff
Change information
Files:
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- R go/src/infra/cros/lib/bols/cmd_service.go
- R go/src/infra/cros/lib/bols/container_utils.go
- R go/src/infra/cros/lib/bols/docker_executor.go
- A go/src/infra/cros/lib/bols/dolos_service.go
- R go/src/infra/cros/lib/bols/file_service.go
- R go/src/infra/cros/lib/bols/ip_cache.go
- R go/src/infra/cros/lib/bols/local_dev.go
- R go/src/infra/cros/lib/bols/logger.go
- A go/src/infra/cros/lib/bols/service.go
- R go/src/infra/cros/lib/bols/servod_control_service.go
- R go/src/infra/cros/lib/bols/servod_lifecycle_service.go
- R go/src/infra/cros/lib/bols/tar_utils.go
- R go/src/infra/cros/lib/bols/util.go
Change size: L
Delta: 14 files changed, 171 insertions(+), 90 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:50 PM (1 hour ago) 7:50 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Refactor container-centric BOLS handlers into lib/bols
Move container-centric BOLS handlers (file_service, servod_lifecycle_service,
servod_control_service, dolos_service, cmd_service, ip_cache, local_dev, container_utils,
tar_utils, logger, util, docker_executor) into lib/bols to enable reuse across
BOLS runner implementations.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I76d54dc77c0dca1e8d8fc04e9bce5942a9290a6f
Change diff
Change information
Files:
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- R go/src/infra/cros/lib/bols/cmd_service.go
- R go/src/infra/cros/lib/bols/container_utils.go
- R go/src/infra/cros/lib/bols/docker_executor.go
- A go/src/infra/cros/lib/bols/dolos_service.go
- R go/src/infra/cros/lib/bols/file_service.go
- R go/src/infra/cros/lib/bols/ip_cache.go
- R go/src/infra/cros/lib/bols/local_dev.go
- R go/src/infra/cros/lib/bols/logger.go
- A go/src/infra/cros/lib/bols/service.go
- R go/src/infra/cros/lib/bols/servod_control_service.go
- R go/src/infra/cros/lib/bols/servod_lifecycle_service.go
- R go/src/infra/cros/lib/bols/tar_utils.go
- R go/src/infra/cros/lib/bols/util.go
Change size: L
Delta: 15 files changed, 173 insertions(+), 152 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
See Wai Fu (Gerrit)
8:38 PM (21 minutes ago) 8:38 PM
to Otabek Kasimov, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Otabek Kasimov
See Wai Fu voted and added 1 comment![]( "Open in Gerrit")
Votes added by See Wai Fu
| Code-Review | +1 |
1 comment
File go/src/infra/cros/lib/bols/service.go
Line 49, Patchset 1:
ipCache: NewIPCacheManager(),See Wai Fu . unresolved
Jetski gave me this comment. Not necessary, but it is safer.
```
return &ContainerService{
logPath: logPath,
port: port,
devMode: devMode,
NetworkName: networkName,
logger: log.Default(), // Provide fallback logger to prevent nil dereference
executors: make(map[string]CommandExecutor),
ipCache: NewIPCacheManager(),
}
}
```
Related details
Attention is currently required from:
- Otabek Kasimov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages