[WIP] Cookie prefetching (NEW) [chromium/src : main]

0 views
Skip to first unread message

AI Code Reviewer (Gerrit)

unread,
Jul 8, 2026, 6:31:53 AM (yesterday) Jul 8
to Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, James Maclean, alexmo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/dom/document.h
Line 63, Patchset 1 (Latest):#include "third_party/blink/public/web/web_prefetched_cookie_state.h"
AI Code Reviewer . unresolved

Blink Style Guide: Dependencies. Code in `core/` should not depend on `public/web/`. Dependencies must flow from `public/web` to `core/`. Consider unpacking `WebPrefetchedCookieState` in `core/exported/web_document.cc` and passing its components (e.g., `String`, `uint64_t`, `base::ReadOnlySharedMemoryRegion`) to `Document::SetCookieManager` instead.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I31a429b07d9176e9aeb642fee7e0e23ac71bf0ab
Gerrit-Change-Number: 8062312
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 10:31:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
5:48 AM (8 hours ago) 5:48 AM
to Victor Vianna, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, James Maclean, asvitkine...@chromium.org, storage...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Victor Vianna

Message from chrom...@appspot.gserviceaccount.com

😿 Job android-pixel9-pro-xl-perf/loadline2-phone.crossbench failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1699e1d8290000

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I31a429b07d9176e9aeb642fee7e0e23ac71bf0ab
Gerrit-Change-Number: 8062312
Gerrit-PatchSet: 7
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 09:48:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
12:02 PM (2 hours ago) 12:02 PM
to Victor Vianna, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, James Maclean, asvitkine...@chromium.org, storage...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Victor Vianna

Message from chrom...@appspot.gserviceaccount.com

📍 Job android-pixel9-pro-xl-perf/loadline2_phone.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13badfe8290000

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I31a429b07d9176e9aeb642fee7e0e23ac71bf0ab
Gerrit-Change-Number: 8062312
Gerrit-PatchSet: 8
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 16:02:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
1:27 PM (6 minutes ago) 1:27 PM
to Victor Vianna, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, James Maclean, asvitkine...@chromium.org, storage...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Victor Vianna

Message from chrom...@appspot.gserviceaccount.com

📍 Job android-pixel9-pro-xl-perf/loadline2_phone.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1646c497c90000

Gerrit-Comment-Date: Thu, 09 Jul 2026 17:27:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages