[AtMemory][Android] Move to half height when loading [chromium/src : main]
Atalyk Akash (Gerrit)
Atalyk Akash voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Piotr Kotynia
- Timofey Chudakov
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Kotynia (Gerrit)
Piotr Kotynia added 2 comments![]( "Open in Gerrit")
if (mContent.getContentView().isAttachedToWindow()) {
mContent.getContentView()
.post(() -> mBottomSheetController.expandSheet(/* animate= */ true));
} else {
mBottomSheetController.expandSheet(/* animate= */ true);
}could you add a short comment what is this logic doing?
mDelegate.requestExpandSheet(/* expandInHalfHeight= */ true);why do we want to expain to half in this case?
Related details
- Atalyk Akash
- Timofey Chudakov
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atalyk Akash (Gerrit)
Atalyk Akash abandoned this change.
Atalyk Akash abandoned this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atalyk Akash (Gerrit)
Atalyk Akash restored this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atalyk Akash (Gerrit)
Atalyk Akash added 2 comments![]( "Open in Gerrit")
if (mContent.getContentView().isAttachedToWindow()) {
mContent.getContentView()
.post(() -> mBottomSheetController.expandSheet(/* animate= */ true));
} else {
mBottomSheetController.expandSheet(/* animate= */ true);
}could you add a short comment what is this logic doing?
Done
mDelegate.requestExpandSheet(/* expandInHalfHeight= */ true);why do we want to expain to half in this case?
Discuss this with UX team, they said that during loading the sheet should move half height. crbug.com/538102617
Related details
- Piotr Kotynia
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Kotynia (Gerrit)
Piotr Kotynia added 1 comment![]( "Open in Gerrit")
mDelegate.requestExpandSheet(/* expandInFullHeight= */ true);So I don't fully undestand: CL message suggest that we want to "Move to half height when loading", but we actually request for full height after sending a query?
Related details
- Atalyk Akash
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atalyk Akash (Gerrit)
Atalyk Akash added 1 comment![]( "Open in Gerrit")
mDelegate.requestExpandSheet(/* expandInFullHeight= */ true);So I don't fully undestand: CL message suggest that we want to "Move to half height when loading", but we actually request for full height after sending a query?
Probably the naming is confusing. The expandSheet method in the bottom sheet actually reevaluates the content of the sheet and adjust its height. I was following the same naming for Delegate method.
Related details
- Piotr Kotynia
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atalyk Akash (Gerrit)
Atalyk Akash added 1 comment![]( "Open in Gerrit")
mDelegate.requestExpandSheet(/* expandInFullHeight= */ true);Atalyk AkashSo I don't fully undestand: CL message suggest that we want to "Move to half height when loading", but we actually request for full height after sending a query?
Probably the naming is confusing. The expandSheet method in the bottom sheet actually reevaluates the content of the sheet and adjust its height. I was following the same naming for Delegate method.
In other words, expandSheet reevaluates the content height and then moves to half height state. But for search focused case, it is still be full height because the getHalfHeightRatio is DISABLED when search has focus.