[mojo] Change error behaviour for incoming message processing [chromium/src : main]

0 views

Skip to first unread message

Fred Shih (Gerrit)

unread,

Dec 25, 2025, 8:20:40 PM (yesterday) Dec 25

to Alex Gough, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Alex Gough

Fred Shih added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Fred Shih . resolved

merry holidays! this looks bad, but isn't *that* bad. Most of the changes stem from changing DeserializationException to a checked exception, which infected all the call sites...

Open in Gerrit

Related details

Attention is currently required from:

Alex Gough

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fred Shih (Gerrit)

unread,

7:18 PM (4 hours ago) 7:18 PM

to Peter Beverloo, AyeAye, Alex Gough, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, sloboda...@chromium.org, lizeb+watch...@chromium.org, webauthn...@chromium.org

Attention needed from Alex Gough

Fred Shih added 2 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Fred Shih . resolved

sorry that this change really ballooned, but I ended up running into a lot of unexpected behaviours. Will add feature owners if the overall approach looks reasonable.

File mojo/golden/generated/java/org/chromium/golden/BasicStruct.java.golden

Line 54, Patchset 4:

        if (decoder0 == null) {
            return null;
        }

Fred Shih . unresolved

No idea why we even allow this. Is there a use case where we'd want decode to return null because a null decoder was passed in?