Remove deprecated threat_pattern_type from ThreatMetadata [chromium/src : main]

0 views
Skip to first unread message

thefrog (Gerrit)

unread,
Jul 7, 2026, 11:57:34 AM (23 hours ago) Jul 7
to Charles Harrison, Daniel White, Anunoy Ghosh, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, subresource-f...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Anunoy Ghosh, Charles Harrison and Daniel White

thefrog added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
thefrog . resolved
- @anu...@chromium.org: please review chrome/browser/safe_browsing and components/safe_browsing changes
 - @cshar...@chromium.org: please review subresource_filter changes
 - @daniel...@google.com: please review ios changes
 
 Thanks!
Open in Gerrit

Related details

Attention is currently required from:
  • Anunoy Ghosh
  • Charles Harrison
  • Daniel White
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf99e169e4cb1df67b6fb9d4ae486e334f03163b
Gerrit-Change-Number: 8047840
Gerrit-PatchSet: 4
Gerrit-Owner: thefrog <the...@chromium.org>
Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Daniel White <daniel...@google.com>
Gerrit-Reviewer: thefrog <the...@chromium.org>
Gerrit-Attention: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Attention: Daniel White <daniel...@google.com>
Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Jul 2026 15:57:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anunoy Ghosh (Gerrit)

unread,
Jul 7, 2026, 1:06:06 PM (22 hours ago) Jul 7
to thefrog, Charles Harrison, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, subresource-f...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Charles Harrison, Daniel White and thefrog

Anunoy Ghosh added 1 comment

Patchset-level comments
Anunoy Ghosh . resolved

LGTM for chrome/browser/safe_browsing/* and components/safe_browsing/*.
Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Harrison
  • Daniel White
  • thefrog
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf99e169e4cb1df67b6fb9d4ae486e334f03163b
Gerrit-Change-Number: 8047840
Gerrit-PatchSet: 4
Gerrit-Owner: thefrog <the...@chromium.org>
Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Daniel White <daniel...@google.com>
Gerrit-Reviewer: thefrog <the...@chromium.org>
Gerrit-Attention: thefrog <the...@chromium.org>
Gerrit-Attention: Daniel White <daniel...@google.com>
Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Jul 2026 17:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anunoy Ghosh (Gerrit)

unread,
Jul 7, 2026, 1:06:44 PM (22 hours ago) Jul 7
to thefrog, Charles Harrison, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, subresource-f...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Charles Harrison, Daniel White and thefrog

Anunoy Ghosh voted and added 1 comment

Votes added by Anunoy Ghosh

Code-Review+1

1 comment

Patchset-level comments
Anunoy Ghosh . resolved

LGTM for real this time :-)

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Harrison
  • Daniel White
  • thefrog
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf99e169e4cb1df67b6fb9d4ae486e334f03163b
    Gerrit-Change-Number: 8047840
    Gerrit-PatchSet: 4
    Gerrit-Owner: thefrog <the...@chromium.org>
    Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
    Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
    Gerrit-Reviewer: Daniel White <daniel...@google.com>
    Gerrit-Reviewer: thefrog <the...@chromium.org>
    Gerrit-Attention: thefrog <the...@chromium.org>
    Gerrit-Attention: Daniel White <daniel...@google.com>
    Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Jul 2026 17:06:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Anunoy Ghosh (Gerrit)

    unread,
    Jul 7, 2026, 2:37:54 PM (20 hours ago) Jul 7
    to thefrog, Charles Harrison, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, subresource-f...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
    Attention needed from Charles Harrison, Daniel White and thefrog

    Anunoy Ghosh voted and added 1 comment

    Votes added by Anunoy Ghosh

    Code-Review+1

    1 comment

    Commit Message
    Line 10, Patchset 5 (Latest):consumer code. V4GetHashProtocolManager
    Anunoy Ghosh . unresolved

    This seems incomplete? Sorry, forgot to mention it last time.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Charles Harrison
    • Daniel White
    • thefrog
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iaf99e169e4cb1df67b6fb9d4ae486e334f03163b
      Gerrit-Change-Number: 8047840
      Gerrit-PatchSet: 5
      Gerrit-Owner: thefrog <the...@chromium.org>
      Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
      Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
      Gerrit-Reviewer: Daniel White <daniel...@google.com>
      Gerrit-Reviewer: thefrog <the...@chromium.org>
      Gerrit-Attention: thefrog <the...@chromium.org>
      Gerrit-Attention: Daniel White <daniel...@google.com>
      Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
      Gerrit-Comment-Date: Tue, 07 Jul 2026 18:37:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      thefrog (Gerrit)

      unread,
      Jul 7, 2026, 4:38:15 PM (18 hours ago) Jul 7
      to Anunoy Ghosh, Charles Harrison, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, subresource-f...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
      Attention needed from Charles Harrison and Daniel White

      thefrog added 1 comment

      Commit Message
      Line 10, Patchset 5:consumer code. V4GetHashProtocolManager
      Anunoy Ghosh . resolved

      This seems incomplete? Sorry, forgot to mention it last time.

      thefrog

      Thanks!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Charles Harrison
      • Daniel White
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iaf99e169e4cb1df67b6fb9d4ae486e334f03163b
        Gerrit-Change-Number: 8047840
        Gerrit-PatchSet: 6
        Gerrit-Owner: thefrog <the...@chromium.org>
        Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
        Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
        Gerrit-Reviewer: Daniel White <daniel...@google.com>
        Gerrit-Reviewer: thefrog <the...@chromium.org>
        Gerrit-Attention: Daniel White <daniel...@google.com>
        Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
        Gerrit-Comment-Date: Tue, 07 Jul 2026 20:38:03 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Anunoy Ghosh <anu...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Charles Harrison (Gerrit)

        unread,
        9:40 AM (1 hour ago) 9:40 AM
        to thefrog, Anunoy Ghosh, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, subresource-f...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
        Attention needed from Daniel White and thefrog

        Charles Harrison voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Daniel White
        • thefrog
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iaf99e169e4cb1df67b6fb9d4ae486e334f03163b
        Gerrit-Change-Number: 8047840
        Gerrit-PatchSet: 6
        Gerrit-Owner: thefrog <the...@chromium.org>
        Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
        Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
        Gerrit-Reviewer: Daniel White <daniel...@google.com>
        Gerrit-Reviewer: thefrog <the...@chromium.org>
        Gerrit-Attention: thefrog <the...@chromium.org>
        Gerrit-Attention: Daniel White <daniel...@google.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 13:40:21 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Daniel White (Gerrit)

        unread,
        9:49 AM (1 hour ago) 9:49 AM
        to thefrog, Charles Harrison, Anunoy Ghosh, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, subresource-f...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
        Attention needed from thefrog

        Daniel White voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • thefrog
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iaf99e169e4cb1df67b6fb9d4ae486e334f03163b
        Gerrit-Change-Number: 8047840
        Gerrit-PatchSet: 6
        Gerrit-Owner: thefrog <the...@chromium.org>
        Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
        Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
        Gerrit-Reviewer: Daniel White <daniel...@google.com>
        Gerrit-Reviewer: thefrog <the...@chromium.org>
        Gerrit-Attention: thefrog <the...@chromium.org>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 13:48:57 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages