Remove non-compact field filling stats metrics [chromium/src : main]
0 views
Skip to first unread message
Jihad Hanna (Gerrit)
Jun 12, 2025, 9:10:43 AM6/12/25
to Dominic Battré, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Dominic Battré
Jihad Hanna voted and added 3 comments![]( "Open in Gerrit")
Votes added by Jihad Hanna
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jihad Hanna . unresolved
Hey Dominic, I'd like your opinion on this:
- We have two kinds of `FieldFillingStats` metrics: One that tells us for each form type how many fields in total in the web were submitted with some status status (Accepted, Edited, etc.) (Split only by form type), and another that tells us for each form type and each status (Accepted, Edited, etc.), how many fields were submitted with that status per single form submission (Split by form type and status).
- The second one seems not useful because we don't have the baseline of how many fields did the submitted form contain in total so I'm not sure what the absolute number is telling us (something that the first generic metric doesn't tell us)
- I have yet to see a case/experiment where we looked at the non-compact one and not the compact one.
Today I was asked why don't we log `Autofill.FieldFillingStats.PostalAddress`, and it turns out that whoever added the logic did correctly log the non-compact one but forgot to log the compact one (which is used a lot in experiments).
Given that this could be causing confusion, I'm proposing to just remove the non-compact version. WDYT?
---
A roughly similar argument can be made about `FieldFilling[Complex]Score` in case you agree we should remove this.
File components/autofill/core/browser/metrics/field_filling_stats_and_score_metrics.cc
Line 263, Patchset 1 (Latest):
postal_address_field_stats);Jihad Hanna . unresolved
... so I added it here.
File tools/metrics/histograms/metadata/autofill/histograms.xml
Line 2907, Patchset 1 (Latest):
<variant name="PostalAddress"/>Jihad Hanna . unresolved
This existed but was never logged...
Related details
Attention is currently required from:
- Dominic Battré
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Battré (Gerrit)
Jun 12, 2025, 9:31:00 AM6/12/25
to Jihad Hanna, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Jihad Hanna
Dominic Battré voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominic Battré
| Code-Review | +1 |
2 comments
File components/autofill/core/browser/metrics/field_filling_stats_and_score_metrics.cc
... so I added it here.
Dominic Battré
Acknowledged
File tools/metrics/histograms/metadata/autofill/histograms.xml
This existed but was never logged...
Attention is currently required from:
- Jihad Hanna
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
Jun 12, 2025, 9:39:44 AM6/12/25
to Florian Leimgruber, Dominic Battré, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Jihad Hanna voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jihad Hanna
| Commit-Queue | +2 |
Hey Dominic, I'd like your opinion on this:
- We have two kinds of `FieldFillingStats` metrics: One that tells us for each form type how many fields in total in the web were submitted with some status status (Accepted, Edited, etc.) (Split only by form type), and another that tells us for each form type and each status (Accepted, Edited, etc.), how many fields were submitted with that status per single form submission (Split by form type and status).
- The second one seems not useful because we don't have the baseline of how many fields did the submitted form contain in total so I'm not sure what the absolute number is telling us (something that the first generic metric doesn't tell us)
- I have yet to see a case/experiment where we looked at the non-compact one and not the compact one.
Today I was asked why don't we log `Autofill.FieldFillingStats.PostalAddress`, and it turns out that whoever added the logic did correctly log the non-compact one but forgot to log the compact one (which is used a lot in experiments).
Given that this could be causing confusion, I'm proposing to just remove the non-compact version. WDYT?
---
A roughly similar argument can be made about `FieldFilling[Complex]Score` in case you agree we should remove this.
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 12, 2025, 9:52:36 AM6/12/25
to Jihad Hanna, Florian Leimgruber, Dominic Battré, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove non-compact field filling stats metrics
This CL:
- Removes Autofill.FieldFillingStats.{FormType}.{Stat} metrics.
- Renames LogCompactFieldFillingStats to LogFieldFillingStats.
- Adds a missing logging call to log the stats of postal address forms.
Bug: 40100455
Change-Id: I5909747adb0eedd3799767c85e748056028042d4
Commit-Queue: Jihad Hanna <jihad...@google.com>
Reviewed-by: Dominic Battré <bat...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473018}
Files:
- M components/autofill/core/browser/metrics/field_filling_stats_and_score_metrics.cc
- M components/autofill/core/browser/metrics/field_filling_stats_and_score_metrics_unittest.cc
- M tools/metrics/histograms/metadata/autofill/histograms.xml
Change size: M
Delta: 3 files changed, 7 insertions(+), 238 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominic Battré
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages