Fix aim chip ring appearance in standby mode [chromium/src : main]

0 views
Skip to first unread message

Patrick Noland (Gerrit)

unread,
Jul 8, 2026, 3:29:12 PM (23 hours ago) Jul 8
to Chromium LUCI CQ, chromium...@chromium.org, ender...@chromium.org
Attention needed from Patrick Noland

Message from Patrick Noland

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Noland
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6855241f82edc64417baa016a6cf96fa800da5c9
Gerrit-Change-Number: 8059885
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Noland <pno...@chromium.org>
Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
Gerrit-Attention: Patrick Noland <pno...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 19:28:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sky Malice (Gerrit)

unread,
Jul 8, 2026, 5:01:23 PM (22 hours ago) Jul 8
to Patrick Noland, Chromium LUCI CQ, chromium...@chromium.org, ender...@chromium.org
Attention needed from Patrick Noland

Sky Malice voted and added 2 comments

Votes added by Sky Malice

Code-Review+1

2 comments

File chrome/browser/ui/android/omnibox/java/res/drawable/activation_chip_focus_ring.xml
Line 11, Patchset 3 (Latest): Bump the horizontal border out so that there is 3dp between it and the pill
inside. 3dp for that space, plus 2 more dp for the width of the border.
Negative inset so that it goes out rather than in. The vertical border is
Sky Malice . unresolved

The comment needs updating.

File ui/android/java/src/org/chromium/ui/widget/RippleBackgroundHelper.java
Line 78, Patchset 3 (Latest): @Px int horizontalInset) {
Sky Malice . unresolved

param and elsehwere

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Noland
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6855241f82edc64417baa016a6cf96fa800da5c9
Gerrit-Change-Number: 8059885
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Noland <pno...@chromium.org>
Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
Gerrit-Attention: Patrick Noland <pno...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 21:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Noland (Gerrit)

unread,
12:03 PM (3 hours ago) 12:03 PM
to Sky Malice, Chromium LUCI CQ, chromium...@chromium.org, ender...@chromium.org
Attention needed from Sky Malice

Patrick Noland voted and added 2 comments

Votes added by Patrick Noland

Commit-Queue+2

2 comments

File chrome/browser/ui/android/omnibox/java/res/drawable/activation_chip_focus_ring.xml
Line 11, Patchset 3: Bump the horizontal border out so that there is 3dp between it and the pill

inside. 3dp for that space, plus 2 more dp for the width of the border.
Negative inset so that it goes out rather than in. The vertical border is
Sky Malice . resolved

The comment needs updating.

Patrick Noland

Done

File ui/android/java/src/org/chromium/ui/widget/RippleBackgroundHelper.java
Line 78, Patchset 3: @Px int horizontalInset) {
Sky Malice . resolved

param and elsehwere

Patrick Noland

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Sky Malice
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6855241f82edc64417baa016a6cf96fa800da5c9
    Gerrit-Change-Number: 8059885
    Gerrit-PatchSet: 5
    Gerrit-Owner: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
    Gerrit-Attention: Sky Malice <sk...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 16:03:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Sky Malice <sk...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sky Malice (Gerrit)

    unread,
    12:06 PM (3 hours ago) 12:06 PM
    to Patrick Noland, Chromium LUCI CQ, chromium...@chromium.org, ender...@chromium.org
    Attention needed from Patrick Noland

    Sky Malice voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Patrick Noland
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6855241f82edc64417baa016a6cf96fa800da5c9
      Gerrit-Change-Number: 8059885
      Gerrit-PatchSet: 5
      Gerrit-Owner: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-Attention: Patrick Noland <pno...@chromium.org>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 16:06:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Patrick Noland (Gerrit)

      unread,
      12:21 PM (2 hours ago) 12:21 PM
      to Sky Malice, Chromium LUCI CQ, chromium...@chromium.org, ender...@chromium.org

      Patrick Noland voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6855241f82edc64417baa016a6cf96fa800da5c9
      Gerrit-Change-Number: 8059885
      Gerrit-PatchSet: 5
      Gerrit-Owner: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 16:21:06 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      12:25 PM (2 hours ago) 12:25 PM
      to Patrick Noland, Sky Malice, chromium...@chromium.org, ender...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Fix aim chip ring appearance in standby mode

      * Remove the outer standby ring when the chip is selected
      * Add a horizontal inset, replacing - margin for the foreground
        drawable, to prevent it from being clipped
      * Add support for horizontal inset on a ButtonCompat
      * Fix the way we reset text when keyboard navigating in ZPS;
        revertChanges was putting us back into standby
      Bug: 524680838
      Change-Id: I6855241f82edc64417baa016a6cf96fa800da5c9
      Commit-Queue: Patrick Noland <pno...@chromium.org>
      Reviewed-by: Sky Malice <sk...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1659616}
      Files:
      • M chrome/browser/ui/android/omnibox/java/res/drawable/activation_chip_focus_ring.xml
      • M chrome/browser/ui/android/omnibox/java/res/layout/fusebox_layout.xml
      • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
      • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java
      • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediatorTest.java
      • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
      • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarTabletUnitTest.java
      • M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/chips/ChipView.java
      • M ui/android/java/res/values/attrs.xml
      • M ui/android/java/src/org/chromium/ui/widget/ButtonCompat.java
      • M ui/android/java/src/org/chromium/ui/widget/RippleBackgroundHelper.java
      Change size: M
      Delta: 11 files changed, 85 insertions(+), 58 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Sky Malice
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6855241f82edc64417baa016a6cf96fa800da5c9
      Gerrit-Change-Number: 8059885
      Gerrit-PatchSet: 6
      Gerrit-Owner: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages