Use USVString instead of DOMString/CSSOMString in css/cssom [chromium/src : main]

0 views
Skip to first unread message

Suyeon Ji (Gerrit)

unread,
Jan 16, 2026, 6:58:49 AM (yesterday) Jan 16
to Rune Lillesveen, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Rune Lillesveen

Suyeon Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 9:
Suyeon Ji . resolved

Hi, Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id095593c97a98acd2c2d707d38af4079df869b14
Gerrit-Change-Number: 7362213
Gerrit-PatchSet: 11
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 11:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Jan 16, 2026, 10:42:55 AM (yesterday) Jan 16
to Suyeon Ji, Rune Lillesveen, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji

Rune Lillesveen added 1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Rune Lillesveen . unresolved

I found this discussion, and I'm unsure what to do here:

https://github.com/w3c/css-houdini-drafts/issues/687

I don't have a deep understanding of the differences. Do we have really good reasons to do this change now?

Open in Gerrit

Related details

Attention is currently required from:
  • Suyeon Ji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id095593c97a98acd2c2d707d38af4079df869b14
    Gerrit-Change-Number: 7362213
    Gerrit-PatchSet: 11
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 15:42:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Suyeon Ji (Gerrit)

    unread,
    1:28 AM (11 hours ago) 1:28 AM
    to Rune Lillesveen, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Rune Lillesveen

    Suyeon Ji added 1 comment

    Patchset-level comments
    Rune Lillesveen . resolved

    I found this discussion, and I'm unsure what to do here:

    https://github.com/w3c/css-houdini-drafts/issues/687

    I don't have a deep understanding of the differences. Do we have really good reasons to do this change now?

    Suyeon Ji

    Thanks for the insight. I actually assumed that moving to USVString would improve interoperability, especially since Firefox uses it and Chromium supports it now. However, I fully understand the established WG consensus to use CSSOMString.

    Since this patch doesn't offer immediate benefits in light of that decision, I'll go ahead and close this CL. Thanks for the review!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rune Lillesveen
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id095593c97a98acd2c2d707d38af4079df869b14
      Gerrit-Change-Number: 7362213
      Gerrit-PatchSet: 11
      Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Comment-Date: Sat, 17 Jan 2026 06:27:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Suyeon Ji (Gerrit)

      unread,
      3:17 AM (9 hours ago) 3:17 AM
      to Rune Lillesveen, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

      Suyeon Ji abandoned this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: abandon
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages