nested app menu: Move "Add tab to group" item to under tab groups [chromium/src : main]

0 views

Skip to first unread message

Masa Fujita (Gerrit)

unread,

4:04 AM (9 hours ago) 4:04 AM

to chromium...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

nested app menu: Move "Add tab to group" item to under tab groups

Per UX direction, instead of having a separate "Add tab to group" menu
item that lists all the tab groups, we add an "Add to tab group" item to
each of the listed tab group item options.

Before: http://screenshot/3eDmRZjvrtBTeuZ
After: http://screenshot/7PN8MyYU4txwpkF

Bug: 509065807

Change-Id: I3e213e4310c74b431987596773268d4e64f6fb60

Change diff

Change information

Files:

M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilder.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilderUnitTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegateUnitTest.java

Change size: L

Delta: 3 files changed, 113 insertions(+), 198 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

4:05 AM (9 hours ago) 4:05 AM

to chromium...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

5:04 AM (8 hours ago) 5:04 AM

to Chromium LUCI CQ, chromium...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages