Add tests for group randomization with different layer member ID specs. [chromium/src : main]
Caitlin Fischer (Gerrit)
Caitlin Fischer voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Alexei Svitkine
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Alexei Svitkine added 1 comment![]( "Open in Gerrit")
- Caitlin Fischer
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Caitlin Fischer (Gerrit)
Caitlin Fischer voted and added 2 comments![]( "Open in Gerrit")
Votes added by Caitlin Fischer
| Commit-Queue | +1 |
You have some build errors.
Indeed. I hadn't realized that base::StrCat() wasn't a drop-in replacement for absl::StrCat() :-(
// studies' LayerMemberReference.layer_member_ids field or when going fromNote to self: Tweak the comment to make it clear that the client's slot's member needs to be unchanged.
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Caitlin Fischer (Gerrit)
Caitlin Fischer added 1 comment![]( "Open in Gerrit")
// studies' LayerMemberReference.layer_member_ids field or when going fromNote to self: Tweak the comment to make it clear that the client's slot's member needs to be unchanged.
- Alexei Svitkine
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Caitlin Fischer (Gerrit)
Caitlin Fischer voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Alexei Svitkine (Gerrit)
Alexei Svitkine added 4 comments![]( "Open in Gerrit")
user_data_dir.AppendASCII("VariationsSeedV2");I see this is being done in other tests too, but it's pretty fragile.
WDYT about making a helper function to components/variations/variations_test_utils.h to write to the seed file?
In fact, then you can pass in StoredSeedInfo and let the compress/serialize be done internally.
Or better yet, pass in the seed itself, and have the helper write to both the local state and to the file.
// Verify that study-group randomization remains the same for a given clientI find this setup is still a bit hard to follow.
If I understand correctly, I think you have some number of test cases above that have the same expected fields. So perhaps it could be helpful to group them together with comments?
// order and weight, etc.) when (A) updatingNit: For readability, add a : after when and wrap before (A) and before (B).
// Determines the value returned by GetGoogleWebEntropyLimitInBits() in tests.Nit: I find "Determines" wording weird given it's not doing some logic to figure it out, but instead is just a setter.
Also, right now you have no way to unset this. Since you're just using it from browsertests, that's OK since it doesn't persist to other tests.
But then, please add a comment here saying that currently this doesn't get unset and thus it's only safe to use from browsertests. If this is to be used in unit tests, a way to clear it should be added.
(Or just add the way to clear it.)
Related details
- Caitlin Fischer
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |